cr134
#27172
Draft
cr134
#27172
+7,262
−5,994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ored Chromium change: https://chromium.googlesource.com/chromium/src/+/20d5954df30f7c8db5731ae2161d75fdf4630282 [Anchor] Short circuit focus animation when controls are bottom-anchored This is one piece of a larger set of changes implementing the omnibox focus animation for bottom-anchored toolbar. Note that it also: * Removes old logic that inadvertently canceled the defocus animation (woops) * Wires a function to autocomplete allowing it to trigger its own logic for this scenario Bug: 369134015
Chromium change: https://chromium.googlesource.com/chromium/src/+/0365212264baff897e4136eaac12d4805014dc22 De-dagger NotificationManagerProxy and clean up test mocking. NotificationManagerProxy was mocked in many different ways all over the place, this change unifies them. Low-Coverage-Reason: LARGE_SCALE_REFACTOR Bug: 377144584
…gate Chromium change: https://source.chromium.org/chromium/chromium/src/+/638867ad1cee0a821c1010af59050c68fe2cc9c9 commit 638867ad1cee0a821c1010af59050c68fe2cc9c9 Author: Maggie Jennings <[email protected]> Date: Fri Nov 15 14:52:11 2024 +0000 [iOS] Clean up unused enable_do_not_track pref This feature has not worked and the UI has been removed for a long time (see https://crbug.com/41178064) Bug: b:378728339
Chromium change: https://chromium.googlesource.com/chromium/src/+/9d67147896f782f3d7d740022783ddce6fcff81d [Anchor] Hide animation driver logic behind interface * Implement second version of this logic that is unsynced * Decide which impl to instantiate in initializeAnimationDriver * Add a noop impl for when neither one applies Bug: 369134015
Chromium change: https://chromium.googlesource.com/chromium/src/+/726b6623ef36168b805cafe6dfb48b2d51bc4ff6 Add toggle for v8 optimization for Android in settings This CL adds a "v8 optimization" entry to - The "Site settings" page - The "Privacy and Security" page This matches settings in desktop Chrome BUG=378076277 Change-Id: I90b41398fccd6bd758519ce97b16182734e3e8a3
../../chrome/common/importer/firefox_importer_utils.cc:335:38: error: use of undeclared identifier 'IDS_IMPORT_FROM_ICEWEASEL'
335 | return l10n_util::GetStringUTF16(IDS_IMPORT_FROM_ICEWEASEL);
| ^
../../chrome/common/importer/firefox_importer_utils.cc:336:36: error: use of undeclared identifier 'IDS_IMPORT_FROM_FIREFOX'
336 | return l10n_util::GetStringUTF16(IDS_IMPORT_FROM_FIREFOX);
| ^
2 errors generated.
Upstream has these strings only for non-Android platforms, but we are
using the importer code on Android as well, so the string need to be
re-added for Android.
This may eventually be fixed into cxxbridge upstream, but for now we rely on this patch to fix some breakage with span. Chromium change: https://chromium.googlesource.com/chromium/src/+/68162a69de662203c2b5d69673f7db9696045492 commit 68162a69de662203c2b5d69673f7db9696045492 Author: Adrian Taylor <[email protected]> Date: Tue Nov 19 20:16:08 2024 +0000 Roll cxxbridge-cmd: 1.0.129 => 1.0.130 in //third_party/rust. This CL has been created semi-automatically. The expected review process and other details can be found at //tools/crates/create_update_cl.md Updated crates: * cxxbridge-cmd: 1.0.129 => 1.0.130 Chromium `supply-chain/config.toml` policy requires that the following audit criteria are met (note that these are the *minimum* required criteria and `supply-chain/audits.toml` can and should record a stricter certification if possible; see also //docs/rust-unsafe.md): * [email protected]: crypto-safe, safe-to-run Bug: None
Chromium change: https://source.chromium.org/chromium/chromium/src/+/f84431d2e5ead09c6934890eb4c11eeb3eb0c4b4 commit f84431d2e5ead09c6934890eb4c11eeb3eb0c4b4 Author: Michael Wojcicka <[email protected]> Date: Fri Nov 15 20:25:30 2024 +0000 Task Manager Refresh - Implement metrics for different opening sources - Added 4 new browser_command ids: - IDC_TASK_MANAGER_APP_MENU (Canonically "More Tools") - IDC_TASK_MANAGER_CONTEXT_MENU (Right Click Menu, or Toolbar) - IDC_TASK_MANAGER_SHORCUT (Shift/Search+Esc, or custom shortcut) - IDC_TASK_MANAGER_MAIN_MENU (Menu bar in macOS or KDE env.) - Tracked down all the invocation locations for TaskManager and updated their browser_command id to the appropriate version. - Some locations call chrome::OpenTaskManager() directly, updated those manually to use the correct StartAction. - Any locations that were not specified (e.g. BackgroundModeManager, unit tests, etc.) will default to using kOther. Bug: b:366296185
This just preempts a header to avoid an unwanted substitution.
The signature of the changed, which is incosequential for the override itself. Chromium change: https://chromium.googlesource.com/chromium/src/+/2e0675aa8312c555c8a8da67c2a62f7194ef117e commit 2e0675aa8312c555c8a8da67c2a62f7194ef117e Author: Christoph Schwering <[email protected]> Date: Tue Nov 19 15:12:42 2024 +0000 [Autofill] Let AutofillClient::GetPersonalDataManager() return reference This CL changes the return type of AutofillClient::GetPersonalDataManager() from pointer to reference. The motivation is that - most callsites do not null-check the returned pointer, and - luckily, no existing existing call may return a nullptr. That is because - ChromeAutofillClient, ChromeAutofillClientIOS, and WebViewAutofillClientIOS always return non-nullptr, and - AndroidAutofillClient may return nullptr but is never called. This CL therefore makes the return type a reference and marks AndroidAutofillClient::GetPersonalDataManager() as NOTREACHED() (it may be erased by addressing crbug.com/378952614). See crbug.com/379646966 for further analysis. Bug: 379646966
This field is gone from the codebase, and it was unused prior to that. It is only used in brave during a test. Chromium change: https://chromium.googlesource.com/chromium/src/+/ef0a4447e94a75db25377ff5ecc0e9e29a6be500 commit ef0a4447e94a75db25377ff5ecc0e9e29a6be500 Author: Will Harris <[email protected]> Date: Tue Nov 19 19:42:01 2024 +0000 Remove DefaultSearchProviderID functionality This is not used anywhere - the last access of this was removed in 2014 in https://codereview.chromium.org/268643002 so now the underlying functionality can safely be removed. BUG=379818905
Chormium change: https://source.chromium.org/chromium/chromium/src/+/c7c2131f0802a47d1ca20033fc4f68c33912fc9f commit c7c2131f0802a47d1ca20033fc4f68c33912fc9f Author: Steven Holte <[email protected]> Date: Tue Nov 5 21:07:37 2024 +0000 Remove IsOnDeviceModelAdaptationEnabled. * Removes support for kModelAdaptationCompose = Disabled * Removes support for kOnDeviceModelTestFeature with "enable_adaptation" = false. * Eliminates IsOnDeviceModelAdaptationEnabled as redundant with IsOnDeviceModelEnabled. * Consolidates IsOnDeviceModelEnabled and GetOptimizationTargetFor..., since we don't need the target if it's not enabled. Bug: 376754799
Chromium change: https://chromium.googlesource.com/chromium/src/+/1598764f95396242e0ddfc47e43e5133c2bd8da3 Move AccessibilitySettings to the accessibility component This CL moves the AccessibilitySettings class to the accessibility component: //components/browser_ui/accessibility The class has previously been tied to //chrome/browser, even though there was a delegate to provide embedder-specific implementations. We have moved all deps to the delegate, and now AccessibilitySettings depends only on //content_public/ and //components/, and we can move this to be alongside the rest of the accessibility browser_ui files. AX-Relnotes: N/A Bug: 379128588
Chromium change: https://chromium.googlesource.com/chromium/src/+/272a97cf5dd0cb0319ce98fd6c726e4c47beda76 Create EdgeToEdgeSystemBarColorHelper in the E2EManager With this change, the E2EManager will create the EdgeToEdgeSystemBarColorHelper for managing system bar coloring edge-to-edge. EdgeToEdgeSystemBarColorHelper will receive a supplier from ChromeBaseAppCompatActivity through the E2EManager for coloring Chrome-based system bars (as opposed to the OS system bars from the Window) - for most activities, this will be the EdgeToEdgeLayout if the edge-to-edge-everywhere flag is enabled, though the ChromeTabbedActivity will instead supply the bottom chin. Currently, this doesn't fully support the status bar color, the EdgeToEdgeSystemBarColorHelper will have to be expanded to fully account for the status bar and top insets. Bug: 377959835
Error fixed: ld.lld: error: undefined symbol: GetProfilesINI() >>> referenced by firefox_importer_utils.cc:62 (../../../src/chrome/common/importer/firefox_importer_utils.cc:62) >>> obj/chrome/common/importer/importer/firefox_importer_utils.o:(GetFirefoxDetails(std::__Cr::basic_string<char, std::__Cr::char_traits<char>, std::__Cr::allocator<char>> const&))
This reverts commit 9ee702c. Chromium revert: https://chromium.googlesource.com/chromium/src/+/ae3467daf012f1bca7e5dc54d2cd2b65746f8262 commit ae3467daf012f1bca7e5dc54d2cd2b65746f8262 Author: Fikre Mengistu <[email protected]> Date: Wed Nov 20 17:34:00 2024 +0000 Revert "adding ukm metrics to track webauthn interactions with UCC heuristics" This reverts commit 8799e49ae318524e9f7f864fb1d3aff451d0e16c. Reason for revert: https://issues.chromium.org/379476398 Original change's description: > adding ukm metrics to track webauthn interactions with UCC heuristics > > -adding an "interaction type" field in the RedirectHeuristic.CookieAccess2 ukm metric > -modifying the redirect heuristic tab helper to set the interaction type field > > UKM collection review: https://docs.google.com/document/d/1dogmwtbUU0MEwL5RKICv47Ly_RnxBJhRuJHvMwsKrqs/edit?usp=sharing > Bug: 40948689 > > Change-Id: I27c08fe15d26a650fc0c9a68cd409f195eadeeaf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5982879 > Commit-Queue: Fikre Mengistu <[email protected]> > Reviewed-by: Alexei Svitkine <[email protected]> > Reviewed-by: Joshua Hood <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1383731} Bug: 40948689
This is just a simple path reorganising. Chromium change: https://chromium.googlesource.com/chromium/src/+/7697ee463f896649c32634d395921aa6e3ebdc9a commit 7697ee463f896649c32634d395921aa6e3ebdc9a Author: Florian Leimgruber <[email protected]> Date: Wed Nov 20 15:46:38 2024 +0000 Create components/autofill/core/browser/form_import See go/components-autofill-restructure. This CL was auto-generated using the following commands: DIR=components/autofill/core/browser mkdir $DIR/form_import git mv $DIR/address_profile_save_manager* $DIR/form_import/ git mv $DIR/autofill_profile_import_process* $DIR/form_import/ git mv $DIR/autofill_save_update_address_profile_delegate_ios* $DIR/form_import/ git mv $DIR/form_data_importer* $DIR/form_import/ ./tools/git/mass-rename.py git cl format Bug: 376223525
The type for these constants in brave has to match the upstream ones. Chromium change: https://chromium.googlesource.com/chromium/src/+/8e5ac9688e726ba061a6360c924934a9e91673bb commit 8e5ac9688e726ba061a6360c924934a9e91673bb Author: Alison Gale <[email protected]> Date: Wed Nov 20 21:48:30 2024 +0000 Expand learn more links for performance settings pages These changes were suggested by our UXW: https://screenshot.googleplex.com/4u5ymXdiCMM8DjS.png Bug: 362781361
This url constant doesn't seem to be relevant to us as it is part of chromiums privacy sandbox interfaces. Chromium change: https://chromium.googlesource.com/chromium/src/+/4d6b802f4fb5f22ccbea3b4bef5d13fdecdf2530 commit 4d6b802f4fb5f22ccbea3b4bef5d13fdecdf2530 Author: Jacob Stanley <[email protected]> Date: Wed Nov 20 21:44:20 2024 +0000 [Ads API UX Enhancements] Site Suggested Ads - Desktop Connecting strings to page. Screenshots: (1/2): https://screenshot.googleplex.com/3LqJKNAv7WMtdxQ (2/2): https://screenshot.googleplex.com/35VxUPvto8n3QkQ Bug: 374153527
This reverts commit 8b1da82d5142dc67c141dd1b40fac53c2d0e9828.
This function signature has recently changed, however the override being affected is pretty much a stub to the parent class implementation. Chromium change: https://chromium.googlesource.com/chromium/src/+/782dc3d22468fe1fdf78190bfd451b78e782ebfb commit 782dc3d22468fe1fdf78190bfd451b78e782ebfb Author: Kaan Alsan <[email protected]> Date: Fri Jan 3 13:03:32 2025 -0800 Update GetAnchorView to accept ActionIds instead of PageActionIconType This CL is a refactor with no intended changes in behaviour. Previously, GetAnchorView only accepted PageActionIconType, which was used to indirectly retrieve the corresponding ActionId, which is then used to lookup the pinned action view. Now, the ActionId is provided directly. This is required to support the Page Actions framework migration, where PageActionIconType will ultimately be removed and page actions will be identified by their ActionIds. Also, the method now can be used for cases where an action is pinnable but doesn't have a page action, removing duplicated logic. Note: there are multiple callsites that were providing PageActionIconTypes for page actions without action IDs. These are replaced with std::nullopt for now (no change in behaviour), and will be updated as appropriate action IDs are added during the migration. Bug: 386362832 Change-Id: I539d1525a99c43a4aa5980167e004597eda4ba8a Fixed: 386362832
These are fixes to broken transient inclusions.
Chromium has made `AudioContext` a `media::mojom::blink::MediaPlayer` class, which runs into requirements added to it through brave extensions. This change adds the required `RequestFullscreen` method, however the implemention doesn't provide anything additional as this is how the code already behaves. For reference: #21763 Chromium change: https://chromium.googlesource.com/chromium/src/+/2aeb1f458e4bc1be1ba289200ee887c1450922b9 commit 2aeb1f458e4bc1be1ba289200ee887c1450922b9 Author: Tommy Steimel <[email protected]> Date: Mon Jan 6 16:14:04 2025 -0800 Reland "MediaSession: Add WebAudio players as ambient players" This is a reland of commit 30ffd2c53d8ef47112b96893381629ce8583a85b This changes the CL to use std::atomic for the volume multiplier that is written to on the main thread and read from on the audio thread. This should fix the errors on the tsan bots. Original change's description: > MediaSession: Add WebAudio players as ambient players > > When the AudioFocusManager ducks a MediaSessionImpl, it lowers the > volume of its underlying players. This does not currently lower the > volume of WebAudio playback, as AudioContexts are not registered to > the MediaSessionImpl as media players. > > WebAudio has not been registered before as we have not wanted > WebAudio playback to affect audio focus. However, there's an "ambient" > audio focus type that accomplishes just that (currently unused by > MediaSessionImpl). This CL adds "ambient" players to the > MediaSessionImpl which will request ambient focus if there are no other > players requesting a stronger type of audio focus, and makes > AudioContexts register as ambient players. This allows the > AudioFocusManager to know about WebAudio playback so it can force it > to duck when needed. > > On the AudioContext side, it ducks the output volume by scaling the > output audio bus according to the volume multiplier given by the > browser side. > > Bug: 382316461 > Change-Id: Iffdb572d8c999177b35e17c76717460665bcfbbb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6098352 > Reviewed-by: Hongchan Choi <[email protected]> > Commit-Queue: Tommy Steimel <[email protected]> > Reviewed-by: Mark Foltz <[email protected]> > Cr-Commit-Position: refs/heads/main@{#1402262} Bug: 382316461
Chromium change: https://chromium.googlesource.com/chromium/src/+/6f95ddb61a83bd7dff8194765780448f5b874348 Create a new FullscreenSigninAndHistorySyncActivityBase. The SigninAndHistorySync activity can now extend the new ActivityBase. The FirstRunActivityBase extends it as well to limit code duplication. Bug: 349787455
Chromium change: https://source.chromium.org/chromium/chromium/src/+/b985dd9dd7673857bec65e838f75bec4eff229e0 commit b985dd9dd7673857bec65e838f75bec4eff229e0 Author: Caroline Rising <[email protected]> Date: Fri Jan 3 14:26:29 2025 -0800 Create build file for c/b/ui/views/download/ This CL shouldn't change behavior. This is needed for changes to downloads which make the download button pinnable in the toolbar and will add a new controller to BrowserWindowFeatures. Note DownloadToolbarButtonView is not included in the new BUILD target since it would create a new circular dependency with toolbar and those files should be deleted after the downloads toolbar pinning work is complete and launched. Bug: 323962334
Chromium change: https://chromium.googlesource.com/chromium/src/+/35c4db2b9a175 commit 35c4db2b9a17520f5bb30818ebfe4b32b926a45b Author: Ryan Tarpine <[email protected]> Date: Thu Dec 26 13:56:02 2024 -0800 Reland "[DIPS] Move from //chrome to //content." This reverts commit 5783b19dd0f075000eaed395f5a16e513c154fa9. Reason for revert: Fix failing bot. Original change's description: > Revert "[DIPS] Move from //chrome to //content." > > This reverts commit 8915d9509cc62dc22f65e2515c16ac1b271bcc1b. > > Reason for revert: > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/6859/overview > > Original change's description: > > [DIPS] Move from //chrome to //content. > > > > By moving DIPS (Bounce Tracking Mitigations) into //content, it will be > > available for all content embedders, such as Android WebView. > > > > Aside from the obvious file moves, the main changes are: > > - DIPS-related WebContentsObservers are created in > > WebContentsImpl::Init() instead of TabHelpers::AttachTabHelpers() > > - No more DIPSServiceFactory: BrowserContextImpl creates and owns the > > DIPSServiceImpl directly > > - No more DIPSCleanupService (nor its factory): BrowserContextImpl > > deletes the DIPS database file if necessary > > - The logic to trigger DIPS data deletion moved from > > ChromeBrowsingDataRemoverDelegate to BrowsingDataRemoverImpl > > - Tests have to override the ContentBrowserClient instead of setting > > prefs and modifying the HostContentSettingsMap to test 3PC behavior > > - The OpenerHeuristicService was split into two pieces: the part that > > creates cookie grants was moved into //content as the new method > > BrowserContext::BackfillPopupHeuristicGrants(); and the part that > > observes the tracking protection settings stays in //chrome > > observes the tracking protection settings stays in //chrome and calls > > that method. > > - Many FeatureParams were moved from tpcd_experiment_features.h in > > //chrome to //components/content_settings/core/common/features.h > > - components/content_settings/core/common was added to content/DEPS > > - Renamed SiteDataAccessType to DIPSDataAccessType > > > > In followup CLs, we will > > (1) Put all of the DIPS classes, functions, etc into the content namespace (crrev.com/c/6039087) > > (2) Rename DIPS prefixes to Dips to comply with the style guide > > (3) Change b/ bug references to crbug.com/ > > (4) Delete DipsDelegate, moving its methods to ContentBrowserClient > > > > Bug: 40883201
Chromium change: https://chromium.googlesource.com/chromium/src/+/5d75c527e312d commit 5d75c527e312d3c18915498cce640b876a4ec9aa Author: Nihar Majmudar <[email protected]> Date: Thu Jan 2 07:27:32 2025 -0800 [searchbox] Move generic methods up to SearchboxHandler. No-op change. Right now a lot of generic searchbox methods (methods that all searchboxes need) are implemented in RealboxHandler. We want to move these up to the base SearchboxHandler class so other handlers can implement handler specific methods. Follow ups plan to move lens specific code out of the RealboxHandler. Bug: 386819657
Chromium change: https://source.chromium.org/chromium/_/chromium/devtools/devtools-frontend/+/328b3a7c2d447b988e7e26e87af1d6ba30848894 [cleanup] Expose `RenderCoordinator` methods as functions. This is step one to making the `RenderCoordinator` more ergonomic to use (and our codebase slightly more readable): Instead of going via the singleton all the time, just expose the `RenderCoordinator` methods as functions on the `RenderCoordinator` module. That makes code shorter and easier on the eyes, and also doesn't leave the engineer wondering why on earth the `RenderCoordinator` is a class. The second step will be to replace the implementation of the render coordinator with just functions instead of the singleton. Bug: 387186170
This override had to be update as the category declaration has been updated for all those listed. Chromium change: https://chromium.googlesource.com/chromium/src/+/32b001c89dc2f186bfebe1d19a85fc74c61750eb commit 32b001c89dc2f186bfebe1d19a85fc74c61750eb Author: Etienne Pierre-doray <[email protected]> Date: Tue Jan 7 07:44:42 2025 -0800 [tracing] Update builtin categories to use perfetto API This CL simplifies builtin categories definition, and uses SetDescription to declare existing category descriptions. Drive-by: remove some (non-exhaustive) unused categories. Bug: 343404899
This is part of chromium's restructuring of modules, and it only affects inclusion paths, and the path of certain shadow files. Chromium change: https://chromium.googlesource.com/chromium/src/+/477a5ca58b59c4102d309f502060c986bd2a9d23 commit 477a5ca58b59c4102d309f502060c986bd2a9d23 Author: Taylor Bergquist <[email protected]> Date: Tue Jan 7 12:40:40 2025 -0800 Move tab dragging code into its own directory. Bug: 382754501
`OverrideWebPreferences`, and `OverrideWebPreferencesAfterNavigation` have had MPArch args added to them. These arguments can be just passed along to the inherited from class, however the signature has to be corrected in brave code. Chromium change: https://chromium.googlesource.com/chromium/src/+/183b8d70288a27d142029fd529de3a89481eb0df commit 183b8d70288a27d142029fd529de3a89481eb0df Author: Dave Tapuska <[email protected]> Date: Tue Jan 7 10:47:18 2025 -0800 [MPArch Guest View] Make WebPreferences queried per frame tree root Different frame tree roots will require different web preferences (extension applies different settings for apps). We need to be able to query the preferences per frame tree root. Bug: 40202416
This argument was not in use in our code, and it was always being passed as nullptr. Chromium change: https://chromium.googlesource.com/chromium/src/+/d6728815328ff8d406c211e758030170ed7c36df commit d6728815328ff8d406c211e758030170ed7c36df Author: Nihar Majmudar <[email protected]> Date: Tue Jan 7 08:25:57 2025 -0800 [searchbox][lensoverlay] Make LensOverlay use LensSearchboxHandler. Also removes lens specific code from RealboxHandler. Adjusts unit tests to create a base SearchboxHandlerTest which is then extended to create RealboxHandlerTest and LensSearchboxHandlerTest. Change-Id: Ic04a0649bd630c93d79585ea78803ad09aa43e50 Bug: 386819657
This function used to have `need_browser_verification = false` as the last argument, and the only caller in brave was passing the default value, so the drop is inconsequential. Chromium change: https://chromium.googlesource.com/chromium/src/+/db092df3caa844ed656b0685c2ade1374505f84c commit db092df3caa844ed656b0685c2ade1374505f84c Author: Christine Hollingsworth <[email protected]> Date: Tue Jan 7 10:26:12 2025 -0800 [Code Health] Remove stale base::Features - BrowserVerifiedUserActivation* Removes 2 stale base::Features that are disabled by default, with no active finch experiment (and have existed 10+ milestones): BrowserVerifiedUserActivationMouse BrowserVerifiedUserActivationKeyboard CL should not change current behavior. Low-Coverage-Reason: OTHER Bug: 356624074, 356622799, 40091540
As this function has been dropped, this change replaces its use with `AutocompleteInput::SplitKeywordFromInput`, as it was done in chromium too. Chromium change: https://chromium.googlesource.com/chromium/src/+/c9e944bea82550ec3e0973a7dd8a4a093f595a75 commit c9e944bea82550ec3e0973a7dd8a4a093f595a75 Author: Moe Ahmadi <[email protected]> Date: Tue Jan 7 08:12:40 2025 -0800 [omnibox] Moves static methods processing input for keywords to ACInput Bug: 379111291
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: