Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the Element Picker feature by default for Android #27144

Conversation

vadimstruts
Copy link
Collaborator

@vadimstruts vadimstruts commented Jan 7, 2025

Resolves brave/brave-browser#43144

Changed the brave://flags/#block-element-feature default state for Android to be Enabled

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@vadimstruts vadimstruts marked this pull request as ready for review January 7, 2025 16:54
@vadimstruts vadimstruts merged commit 823e971 into master Jan 9, 2025
19 checks passed
@vadimstruts vadimstruts deleted the 43144-enable-the-element-picker-feature-by-default-for-android branch January 9, 2025 10:05
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 9, 2025
brave-builds added a commit that referenced this pull request Jan 9, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable the Element Picker feature by default for Android
3 participants