Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI run for contributor PR #25484 #25691

Merged
11 commits merged into from
Nov 27, 2024

Conversation

brave-builds
Copy link
Collaborator

Description

This PR is created to run CI on the changes proposed in PR #25484 by @jagadeshjai.

This PR should not be merged.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Sep 23, 2024
@github-actions github-actions bot force-pushed the contributor-jagadeshjai-feature__add_option_custom_sync_url branch from 312e242 to 529bb40 Compare October 2, 2024 18:10
@brave-builds
Copy link
Collaborator Author

A Storybook has been deployed to preview UI for the latest push

@github-actions github-actions bot force-pushed the contributor-jagadeshjai-feature__add_option_custom_sync_url branch from 529bb40 to 6612333 Compare October 8, 2024 07:37
@github-actions github-actions bot force-pushed the contributor-jagadeshjai-feature__add_option_custom_sync_url branch 3 times, most recently from 83b5438 to 9d2de48 Compare November 4, 2024 07:27
jagadeshjai and others added 11 commits November 27, 2024 13:49
…ndling custom sync url.

Also show Relauch button and Managed icon when required.

Conflicts:
browser/ui/webui/brave_settings_ui.cc
…ervice via command line before bulding its service in browser context.
…DevServerUrl using chromium_src overrides instead of passing it via command_line
…s_sync_service_[sources/deps].

And Remove some unused includes.
…ock when sync already started and the custom sync url is empty.

Also disable the 'Custom sync URL' block when sync started.
@github-actions github-actions bot force-pushed the contributor-jagadeshjai-feature__add_option_custom_sync_url branch from 9d2de48 to c4b0885 Compare November 27, 2024 10:02
@bsclifton bsclifton closed this pull request by merging all changes into master in d547c86 Nov 27, 2024
@bsclifton bsclifton deleted the contributor-jagadeshjai-feature__add_option_custom_sync_url branch November 27, 2024 21:44
@github-actions github-actions bot added this to the 1.75.x - Nightly milestone Nov 27, 2024
@brave-builds
Copy link
Collaborator Author

Released in v1.75.58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants