Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/brave wallet package #1003

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

akki91
Copy link

@akki91 akki91 commented Nov 4, 2024

@antonok-edm

  • If the brave-wallet-lists npm package is not added, following error is thrown by package-wallet-data-files node script
Unhandled rejection: Error: ENOENT: no such file or directory, open 'node_modules/brave-wallet-lists/manifest.json'
    at Object.openSync (node:fs:573:18)
    at Object.readFileSync (node:fs:452:35)
    at Object.parseManifest (file:///Users//work/brave-core-crx-packager/lib/util.js:137:19)
    at processDATFile (file:///Users//work/brave-core-crx-packager/scripts/packageWalletDataFiles.js:45:31)
    at processJob (file:///Users/work/brave-core-crx-packager/scripts/packageWalletDataFiles.js:60:3)
    at file:///Users//work/brave-core-crx-packager/scripts/packageWalletDataFiles.js:88:5
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5) {
  errno: -2,
  code: 'ENOENT',
  syscall: 'open',
  path: 'node_modules/brave-wallet-lists/manifest.json'
}
  • Another way could be to directly use brave's github repo URL rather than using the public npm package but in that case, npm install will fail unless the following system libs are installed
    librsvg libimagequant pkg-config

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant