-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Sync Server Url configurable in the UI #12314
Comments
@iWangJiaxiang this should already be possible - you can edit the shortcut (or however you launch Brave) to provide a different URL. The argument looks like this: |
@bsclifton Thanks for your quick reply! Do mobile clients (Android/IOS) support this way? |
@iWangJiaxiang good question - they support this, but there is no way to set this. I'll remove |
Is the brave sync server open source too? If so, where can I find it? If Brave is still close enough to Chrome, it might be possible to still set the sync server for mobile (although using a very user-unfriendly way, I hope Brave doesn't follow this pointless policy of not allowing users to easily set up a custom sync server and eventually implements it in a more accessible way, even if it is still hidden in some advance configuration option). |
@llucax the code for the server is open source and can be found here: |
Could it be possible to add an option into the Privacy & Security section, or when you're going to setup the sync for the first time? Firefox allows you to change the sync server URL in the about:config, which is easy enough to setup your own sync server. I kow the about:config doesn't exist in Brave, but something easier than changing in the params of the launcher would be great! |
yup, It'd be great to have this on both mobile and desktop! |
Actually, Brave has brave://flags/ (and a few more, full list in brave://chrome-urls/) , it might may be possible to add it there. |
News about that? On mobile would be great to edit, I don't want to fork the repo and build each time only to change the sync url |
Still nothing as yet? Would love to see this supported in the android app. |
Hi, I started the Sync server via docker on my local system as described in the README.md, but when I start brave with
Any idea what I am doing wrong? Many thanks! |
cc: @yrliou |
@DaCapitalist Could you try |
@yrliou Many thanks. It works with Thanks! |
@DaCapitalist Glad it works now. Your HTTP request & response itself between your browser and your local server is not encrypted, but the actual sync data that being passed in the request and response is always encrypted and will be decrypted on the client side only. (p.s.: meta data is not encrypted but that shouldn't be an issue.) |
Okay, many thanks. |
Should‘t this be a Basic UI change in all clients and not only mobile/android? Thus, I would vote for keeping this also in the desktop (and iOS) backlog. Funktionality should be already existing in Chromium so we only need a setting in the UI to change the Variable. E.g. As @claudio4 suggested. Plus, since firefox is already offering this setting I suggest to increase the priority. What do you think? |
4 months after our discussion I wanted to bring this up again. |
Hi! Same question here : this is the only thing that I need to migrate my family browsers to Brave (from Firefox + self-hosted sync server) |
Hey @bsclifton, is there any update on this? For me, it would be enough to set a URL once (e.g. via |
Like others above, the only thing that keeps me on Firefox is Brave's lack of a proper option. As mentioned in #20431 (comment), using a command-line arg isn't really "safe", as if it's ever missed/forgotten, the browser will just silently publish your data on the public server. Is making this available in brave://flags/ really a large undertaking...? |
I would say yes. All other Issues are accessible for me, but this one is
not anymore. Quite intransparent and sketchy in my personal opinion.
Maybe you should create an issue in your own repo for further discussion?
Nicholas Flamy ***@***.***> schrieb am Di., 9. Apr. 2024,
20:08:
… Did this issue get deleted?
On Wed, Mar 20, 2024 at 7:53 AM Ben Curtis ***@***.***> wrote:
> Are you talking about the fact that it's from master? There's a way to
> mitigate that.
>
> No, I stopped because I realized I had done the UI work and that they'd
> never merge it in, and because I figured out I could use the custom
startup
> to enable the feature.
>
> While a config option for self hosted sync on Android would be nice,
it's
> trivial to do it via the file config and CLI, even without root.
>
> —
> Reply to this email directly, view it on GitHub
> <
#12314 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AHHFT2ISZOCZ2V4TDQ6IJSTYZF2ETAVCNFSM4S7ABFA2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBQHEZTSMRUGAYQ>
> .
> You are receiving this because you commented.Message ID:
> ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#12314 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIYOUMYTZW6HPIWBC7MH4XTY4QVCLAVCNFSM4S7ABFA2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGU4DAOBQGY2A>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
I made a discussion:
flamy-brave#3
…On Tue, Apr 9, 2024 at 2:21 PM ln-12 ***@***.***> wrote:
I would say yes. All other Issues are accessible for me, but this one is
not anymore. Quite intransparent and sketchy in my personal opinion.
Maybe you should create an issue in your own repo for further discussion?
Nicholas Flamy ***@***.***> schrieb am Di., 9. Apr. 2024,
20:08:
> Did this issue get deleted?
>
> On Wed, Mar 20, 2024 at 7:53 AM Ben Curtis ***@***.***> wrote:
>
> > Are you talking about the fact that it's from master? There's a way to
> > mitigate that.
> >
> > No, I stopped because I realized I had done the UI work and that
they'd
> > never merge it in, and because I figured out I could use the custom
> startup
> > to enable the feature.
> >
> > While a config option for self hosted sync on Android would be nice,
> it's
> > trivial to do it via the file config and CLI, even without root.
> >
> > —
> > Reply to this email directly, view it on GitHub
> > <
>
#12314 (comment)>,
>
> > or unsubscribe
> > <
>
https://github.com/notifications/unsubscribe-auth/AHHFT2ISZOCZ2V4TDQ6IJSTYZF2ETAVCNFSM4S7ABFA2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBQHEZTSMRUGAYQ>
>
> > .
> > You are receiving this because you commented.Message ID:
> > ***@***.***>
> >
>
> —
> Reply to this email directly, view it on GitHub
> <
#12314 (comment)>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AIYOUMYTZW6HPIWBC7MH4XTY4QVCLAVCNFSM4S7ABFA2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGU4DAOBQGY2A>
> .
> You are receiving this because you are subscribed to this thread.Message
> ID: ***@***.***>
>
—
Reply to this email directly, view it on GitHub
<#12314 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHHFT2LWDQZRVG5UXSFRINLY4QWRTAVCNFSM4S7ABFA2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TEMBUGU4DENJXGIZA>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Wow, almost 4 years. This issue and #11769 shows that the devs do not care much about sync. |
Hi folks - this issue has been marked as a P5 (priority 5; We absolutely do care about sync. Our sync should be working - please open an issue if you are experiencing a problem. As shared in the second post here, you can use a custom URL: You can also stand up your own sync server- see #12314 (comment) The ask here (for this issue) is to have something in the UI where an advanced user can point at their own sync server. I think the proper place would be a brave://flags entry - because inside brave://settings may be confusing for regular users. If someone was wanting to get started on this, there are some good example pull requests where a brave://flags entry has been added. |
Why? this isn't a trivial matter as it's currently impossible to self host a sync server for one's phone as you can't set launch flags |
*on iPhone. On Android you can do it, even without root, but it makes the browser not very usable. That or you use the QA Preferences which I don't think you're officially supposed to use but I do. |
As discussed in many of the comments:
Yeah not following the rationale there at all.
Rather than just stating it has no priority, care to state why that's the case? Clearly your priority is not based on order (this is old) nor on popularity (this is popular). So what rationale could there be for leaving this at P5, continuing to ignore it, while fixing other lower-interest, more-recent issues?
Not about private/self-hosted sync, evidently
Not with a self-hosted server.
What? That's exactly what this is. This issue was opened 4 years ago to raise a problem that many people are experiencing. |
FYI, I don't think this works anymore, permission denied on Android 14 OneUI 6.1 Samsung S22. |
Huge thanks to @jagadeshjai for getting this done on Desktop! I created a version of this issue for Android. Please see and subscribe to #42570 |
Verification
Case 1: Sync not enabled - Custom sync URL option is shown - PASSED
Case 2: Sync enabled - Custom sync URL option is shown - PASSED
Case 3: Leave existing sync and rejoin the Sync - PASSED
Case 4: Two profiles - Sync with Desktop profile and Mobile profiles - PASSED
Case5: If sync already turned ON and Custom sync URL is empty then the Custom sync URL option should be hidden - PASSED
Case 6: Upgrade - Sync not enabled - PASSED
Case 7: Upgrade - If sync already turned ON upon upgrade, then the Custom sync URL option is hidden - PASSED
|
Changing to |
Staff edit (by @bsclifton)
Custom sync URLs are supported. You can use the command line flag:
--sync-url=https://sync-v2.brave.com/v2
And replace
https://sync-v2.brave.com/v2
with the server of your choosing. Our server implementation is open and can be found here:https://github.com/brave/go-sync
The ask for this issue is to offer a place in the UI to edit the URL.
Description
To protect user data, it is important to support self-hosted sync service for advanced/professional users, for example, those users using NAS/HomeLab/HomeServer. Now the self-hosted feature of Brave sync server v2 is supported according to Issue #51 · brave/go-sync. The next step is supporting custom sync server url in brave-browser! Then the brave browser solution could be important part of homelab stack list!
The text was updated successfully, but these errors were encountered: