Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync devices page is frozen if you provide a custom sync URL that is invalid and try to start a chain #43022

Closed
1 of 6 tasks
MadhaviSeelam opened this issue Dec 20, 2024 · 3 comments

Comments

@MadhaviSeelam
Copy link

Description

Found while testing #12314. After configuring sync server via brave://settings/braveSync and enabling sync, several issues found. Page is frozen. Could not scroll thru page. Device name is not listed. Sync data toggles show icon for managed setting This setting is managed by your administrator but the message on the page is not shown.

Steps to reproduce

  1. Installed 1.75.115
  2. launched Brave
  3. opened brave://settings/braveSync in a new tab
  4. entered https://github.com/brave/go-sync in the text field Custom sync URL
  5. clicked Relaunch button
  6. confirmed Custom Sync URL field is populated with the set value but not grayed out and editable
  7. clicked Start using sync tab above Custom sync URL tab
  8. clicked Start a new Sync Chain >> Computer
  9. clicked OK on Sync Chain code

Actual result

Manage your synced devices page is shown

  • Page is frozen
  • Can't scroll up/down on the page
  • Device names are not listed.
  • Sync data toggles show icon for managed setting This setting is managed by your administrator but the message on the page is not shown.

Expected result

Page should load as expected

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave 1.75.115 Chromium: 132.0.6834.57 (Official Build) nightly (64-bit)
Revision 190df443fcce0f6b7941b8585b756b171f690448
OS Windows 11 Version 24H2 (Build 26100.2314)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

@bsclifton

@bsclifton
Copy link
Member

bsclifton commented Dec 23, 2024

Likely due to this not being a valid sync URL. Someone would need to have a real instance of the sync software setup and ready to accept traffic for sync to actually work.

Behavior expected - but we could handle this better (ex: we can show an error about how server not responding, etc).

More info should show on brave://sync-internals

@bsclifton bsclifton changed the title After configuring sync server via sync settings page and enabling sync, sync devices page is frozen Sync devices page is frozen if you provide a custom sync URL that is invalid and try to start a chain Dec 23, 2024
@bsclifton
Copy link
Member

cc: @rebron @fmarier for triage (P4?)

@bsclifton
Copy link
Member

Closing as this was reverted with brave/brave-core#27136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

2 participants