Improve the webapp performance (WORK IN PROGRESS) #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peeches and cabinet info request client sided to decrease the bundle size of the /deputado-federal/[name], thus, decreasing it's loading time.
Speeches and Cabinet requests loading are now independent, this means that once only speeches request is done, it's respective loading will end. Same for the cabinet request
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
WORK IN PROGRESS. related to #17. |
matmatias
changed the title
The speeches and cabinet requests abortion will be triggered on FederalDeputy component cleanup function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The main bottleneck on the webapp performance is comming from the /deputado-federal/[name] page.
Cause
The cause for this bottleneck is the execessive amout of data being rendered on the server side. This data being (expenses, speeches and cabinet), all of which are arrays of medium to big objects
Solution
Make speeches and cabinet requests to be rendered on the client side. In the moment, the expenses data can't be rendered on the client side because it would impact SEO. Solution to this specific problem is still being discussed.