Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AST: MakeResetStyles #1

Open
wants to merge 8 commits into
base: ast
Choose a base branch
from
Open

AST: MakeResetStyles #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c9b601a
Store makeResetStyles lookup
Mitch-At-Work Dec 12, 2024
edfb3e2
Fix up reset styles
Mitch-At-Work Dec 16, 2024
4084e0d
Remove unneeded function
Mitch-At-Work Dec 16, 2024
6319c9f
Update analyzer to work on nested tokens
Mitch-At-Work Dec 16, 2024
c1c2b9e
Add mergeStyles variable detection
Mitch-At-Work Dec 19, 2024
43d4d28
Update comment
Mitch-At-Work Dec 19, 2024
62b919a
Comment out completed task
Mitch-At-Work Dec 19, 2024
60e3692
Create analysis.json
Mitch-At-Work Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react-components/token-analyzer-preview/library/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ A static analysis tool that scans your project's style files to track and analyz
- `createCustomFocusIndicatorStyle` is a special function that is used throughout the library so we might be able to special case it
- if we have file imports we need to analyze those such as importing base styles
- we also need to ensure var analysis is done correctly after the refactor
- Manage makeResetStyles (likely same as makeStyles)
~~- Manage makeResetStyles (likely same as makeStyles)~~
- Button has some weird patterns in it where it uses makeResetStyles and then uses enums to pull in the styles, we might need to account for those as well.
- what if we have multiple `makeStyles` calls merged, are we handling that correctly or just nuking the conflicts in our output?
- make sure this works with shorthand spread
Expand Down
Loading
Loading