Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Dependencies #17

Merged
merged 6 commits into from
Aug 29, 2023
Merged

Update Dependencies #17

merged 6 commits into from
Aug 29, 2023

Conversation

jplukarski
Copy link
Contributor

@jplukarski jplukarski commented Aug 21, 2023 •
edited
Loading

Makes the following major version updates (I verified that no breaking change should effect us):

  • prettier
  • eslint-plugin-prettier
  • Typescript

Additionally, this includes updates submitted by dependabot in the following PRs:

For internal tracking -> 2912

@jplukarski jplukarski requested a review from a team as a code owner August 21, 2023 19:07
hollabaq86
hollabaq86 suggested changes Aug 23, 2023
View reviewed changes
Copy link

@hollabaq86 hollabaq86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same feedback as what I left in the card-validator library re:CHANGELOG and Node version bump impacts

CHANGELOG.md Show resolved Hide resolved
@jplukarski jplukarski merged commit c72eba6 into main Aug 29, 2023
1 check passed
This was referenced Sep 6, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscarleonnogales oscarleonnogales oscarleonnogales approved these changes

@hollabaq86 hollabaq86 hollabaq86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplukarski @hollabaq86 @oscarleonnogales