[RP1][iOS] Expose PayPal and Venmo App Installed for Merchants #1473
Conversation
|
|
||
| /// Returns true if the proper Venmo app is installed and configured correctly, returns false otherwise. | ||
| @objc public func isVenmoAppInstalled() -> Bool { | ||
| @objc public func isVenmoAppSwitchAvailable() -> Bool { |
There was a problem hiding this comment.
🤔 since this is public this would technically be a breaking change.
@scannillo I know on the original spec for this we had the app install checks in the Venmo and PayPal modules. Thinking more about it, does it make sense to move these into the shopper insights module? Since they are beta methods it could make more sense to keep them contained to that module vs being in the PayPal and Venmo feature.
There was a problem hiding this comment.
Was just looking at this on the Android side and I think it makes more sense to keep these separated in the ShopperInsightsClient - otherwise we need to do refactoring with the current use of app installed methods in the PayPal module to make them public (or duplicate code).
There was a problem hiding this comment.
Cool, totally agree. We can have Sammy update the specs in our wiki pages once she's back. Sorry to change this from what was in the ticket @stechiu - but lets move both of the app installed methods and tests to the Shopper Insights module.
For Shopper Insights, we want to create a public
BTPayPalClient.isPayPalAppInstalledmethod and publicBTVenmoClient.isVenmoAppInstalledmethod inBTPayPalClientSummary of changes
BTPayPalClient.isPayPalAppInstalledandBTVenmoClient.isVenmoAppInstalledmethodsChecklist
Authors