Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Venmo Universal Link Return #1440

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Venmo Universal Link Return #1440

wants to merge 23 commits into from

Conversation

jaxdesmarais
Copy link
Contributor

Summary of changes

⚠️ Pending RCIP approval from Venmo side before merge & release

Checklist

  • Added a changelog entry

Authors

@jaxdesmarais jaxdesmarais marked this pull request as ready for review October 21, 2024 15:13
@jaxdesmarais jaxdesmarais requested a review from a team as a code owner October 21, 2024 15:13
@scannillo
Copy link
Contributor

I think URL schemes on the way back from Venmo was the only remaining need for a merchant to set BTAppContextSwitcher.sharedInstance.returnURLScheme 🥹. Let's deprecate it! 🔥

agedd
agedd approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@agedd agedd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! 🚀

@jaxdesmarais
Copy link
Contributor Author

Adding do not merge while we wait on RCIP approval for merge/release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo approved these changes

@richherrera richherrera richherrera approved these changes

@agedd agedd agedd approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jaxdesmarais @scannillo @agedd @richherrera