Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SUR-370, SRML-64 - Date Picker component issues and improvements #234

Merged
merged 7 commits into from
Dec 30, 2024
Merged

SUR-370, SRML-64 - Date Picker component issues and improvements #234

merged 7 commits into from
Dec 30, 2024

Conversation

jaieds
Copy link
Contributor

@jaieds jaieds commented Dec 30, 2024 •
edited
Loading

Description

  • Added a new prop to set the current value.
  • Fix crashing while selecting year.
  • Improved DatePicker component initial value logic.

Screenshots

Types of changes

How has this been tested?

Checklist:

  • My code is tested
  • My code passes the PHPCS tests
  • I've created the npm build.
  • My code follows accessibility standards
  • My code has proper inline documentation
  • I've included any necessary tests
  • I've included developer documentation
  • I've added proper labels to this pull request

@jaieds jaieds changed the title SUR-370 - Date Picker component issues and improvements SUR-370, SRML-64 - Date Picker component issues and improvements Dec 30, 2024
ravindra114
ravindra114 approved these changes Dec 30, 2024
View reviewed changes
Copy link
Contributor

@ravindra114 ravindra114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Tested and good to go!

@jaieds jaieds merged commit 631d0e7 into staging Dec 30, 2024
2 checks passed
@jaieds jaieds deleted the component-improvement/date-picker branch December 30, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravindra114 ravindra114 ravindra114 approved these changes

@vrundakansara vrundakansara Awaiting requested review from vrundakansara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaieds @ravindra114