Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): fixed incorrect margins on some devices #49

Merged
merged 2 commits into from
Dec 23, 2024
Merged

fix(ui): fixed incorrect margins on some devices #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2bec5c5
fix(ui): fixed incorrect margins on some devices
Adolar0042 Dec 22, 2024
7786bef
fix(ui): fixed more views, yay
Adolar0042 Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/src/main/java/dev/brahmkshatriya/echo/ui/download/DownloadingFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import android.os.Bundle
import android.view.LayoutInflater
import android.view.View
import android.view.ViewGroup
import androidx.core.view.updatePadding
import androidx.fragment.app.Fragment
import androidx.fragment.app.activityViewModels
import androidx.paging.PagingData
Expand Down Expand Up @@ -40,7 +39,6 @@ class DownloadingFragment : Fragment() {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
setupTransition(view)
applyInsets {
binding.exceptionIconContainer.updatePadding(top = it.top)
binding.recyclerView.applyContentInsets(it)
}
applyBackPressCallback()
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/java/dev/brahmkshatriya/echo/ui/extension/ExtensionInfoFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ import android.view.View
import android.view.ViewGroup
import androidx.core.net.toUri
import androidx.core.view.isVisible
import androidx.core.view.updatePadding
import androidx.fragment.app.Fragment
import androidx.fragment.app.activityViewModels
import androidx.lifecycle.lifecycleScope
Expand Down Expand Up @@ -79,7 +78,6 @@ class ExtensionInfoFragment : Fragment() {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
setupTransition(view)
applyInsets {
binding.iconContainer.updatePadding(top = it.top)
binding.nestedScrollView.applyContentInsets(it)
}
applyBackPressCallback()
Expand Down
2 changes: 0 additions & 2 deletions app/src/main/java/dev/brahmkshatriya/echo/ui/login/LoginFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ import android.webkit.WebView
import android.webkit.WebViewClient
import androidx.activity.OnBackPressedCallback
import androidx.core.view.isVisible
import androidx.core.view.updatePadding
import androidx.core.widget.doAfterTextChanged
import androidx.fragment.app.Fragment
import androidx.fragment.app.viewModels
Expand Down Expand Up @@ -98,7 +97,6 @@ class LoginFragment : Fragment() {
override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
setupTransition(view)
applyInsets {
binding.iconContainer.updatePadding(top = it.top)
binding.loginContainer.applyContentInsets(it)
binding.loadingContainer.root.applyContentInsets(it)
}
Expand Down
9 changes: 5 additions & 4 deletions app/src/main/res/layout/fragment_download.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,14 @@
android:id="@+id/exceptionIconContainer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginTop="64dp"
android:layout_marginHorizontal="24dp"
android:paddingTop="64dp"
android:layout_marginBottom="32dp"
android:layout_marginHorizontal="24dp">
android:paddingBottom="32dp">

<ImageView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_width="48dp"
android:layout_height="48dp"
android:contentDescription="@string/album"
android:src="@drawable/art_download_for_offline" />

Expand Down
9 changes: 5 additions & 4 deletions app/src/main/res/layout/fragment_downloading.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,14 @@
android:id="@+id/exceptionIconContainer"
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginTop="64dp"
android:layout_marginHorizontal="24dp"
android:paddingTop="64dp"
android:layout_marginBottom="32dp"
android:layout_marginHorizontal="24dp">
android:paddingBottom="32dp">

<ImageView
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_width="48dp"
android:layout_height="48dp"
android:contentDescription="@string/album"
android:src="@drawable/art_downloading" />

Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/fragment_extension.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,9 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginHorizontal="24dp"
android:layout_marginTop="64dp"
android:paddingTop="64dp"
android:layout_marginBottom="32dp"
tools:layout_marginBottom="54dp">
android:paddingBottom="32dp">

<ImageView
android:id="@+id/extensionIcon"
Expand Down
4 changes: 2 additions & 2 deletions app/src/main/res/layout/fragment_login.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@
android:layout_width="match_parent"
android:layout_height="match_parent"
android:layout_marginHorizontal="24dp"
android:layout_marginTop="64dp"
android:paddingTop="64dp"
android:layout_marginBottom="32dp"
tools:layout_marginBottom="54dp">
android:paddingBottom="32dp">

<ImageView
android:id="@+id/extensionIcon"
Expand Down
Loading