Feat: controller

[rebelonion]

Fixes:

• Calling onExtensionSelected on disabled extensions other than music
• SettingTextInput not updating the shown value immediately after setting

Additions

MessagePostClient

• Allows an extension to hook into mutableMessageFlow to post messages other than errors
• Interface uses delegate/callback

CloseableClient

• Allows extensions to close resources the app closes
• Tied to the player service which should be the last thing running in the app
• In my case this was useful for closing a websocket that otherwise kept running after the app was closed

ControllerClient

• Allows an extension to perform actions directly onto the player
• Uses functions for app->extension communication and callbacks for extension->app communication
• Nicely documented

examples:

Echo Song Skipper

• skips songs based off of song or artist name automatically

Echo Remote Control

• connects to a control app through a websocket server to remotely control playback

[brahmkshatriya]

I am thinking, it would be better to just combine tracker extensions and controller extensions to a simply PlayerExtension (suggest better name if you can think any)
because to me, it seems excessive to have so many types of different extensions.

[brahmkshatriya]

It would be better if you use this class here. (you can move this class to common package)

echo/app/src/main/java/dev/brahmkshatriya/echo/viewmodels/SnackBar.kt

Lines 32 to 35 in 946c84d

	data class Message(
	val message: String,
	val action: Action? = null
	)

[brahmkshatriya]

and also using MutableSharedFlow<Message> instead of those functions.

[brahmkshatriya]

Rename to onClose()

[brahmkshatriya]

I recommend using MutableSharedFlow<T> instead of suspend (t: T) -> Unit for all the var on...Request, and converting this abstract class to an interface.

you can see how MutableSharedFlow works here: https://developer.android.com/kotlin/flow/stateflow-and-sharedflow#sharedflow

Also, it'd be better if you move all data classes and enums to models package

[brahmkshatriya]

Thanks again for the PR!