show button only when there is summary

brahmkshatriya · Aug 7, 2024 · 97eda4b · 97eda4b
1 parent 0b76026
commit 97eda4b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/app/src/main/java/dev/brahmkshatriya/echo/ui/settings/ExtensionFragment.kt b/app/src/main/java/dev/brahmkshatriya/echo/ui/settings/ExtensionFragment.kt
@@ -148,7 +148,7 @@ class ExtensionFragment : BaseSettingsFragment() {
                         it.entryValues = this.entryValues.toTypedArray()
 
                         it.isIconSpaceReserved = false
-                        it.layoutResource = R.layout.preference_summary_button
+                        it.layoutResource = R.layout.preference
                         preferenceGroup.addPreference(it)
                     }
                 }

diff --git a/app/src/main/java/dev/brahmkshatriya/echo/utils/MaterialListPreference.kt b/app/src/main/java/dev/brahmkshatriya/echo/utils/MaterialListPreference.kt
@@ -8,7 +8,7 @@ import dev.brahmkshatriya.echo.R
 
 class MaterialListPreference(context: Context) : ListPreference(context) {
 
-    private var customSummary: String? = null
+    private var customSummary: CharSequence? = null
 
     override fun onBindViewHolder(holder: PreferenceViewHolder) {
         super.onBindViewHolder(holder)
@@ -21,7 +21,12 @@ class MaterialListPreference(context: Context) : ListPreference(context) {
 
     override fun onSetInitialValue(defaultValue: Any?) {
         super.onSetInitialValue(defaultValue)
-        customSummary = summary.toString()
+        customSummary = summary
+        layoutResource = if (customSummary != null){
+            R.layout.preference_summary_button
+        } else {
+            this.layoutResource
+        }
         updateSummary()
     }
 
@@ -46,7 +51,7 @@ class MaterialListPreference(context: Context) : ListPreference(context) {
 
     private fun showSummaryDialog() {
         MaterialAlertDialogBuilder(context)
-            .setMessage(customSummary)
+            .setMessage(customSummary.toString())
             .setPositiveButton(android.R.string.ok, null)
             .show()
     }