fix(ui): fixed more views, yay

brahmkshatriya · Dec 22, 2024 · 7786bef · 7786bef
1 parent 2bec5c5
commit 7786bef
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 14 deletions.
diff --git a/app/src/main/java/dev/brahmkshatriya/echo/ui/download/DownloadingFragment.kt b/app/src/main/java/dev/brahmkshatriya/echo/ui/download/DownloadingFragment.kt
@@ -4,7 +4,6 @@ import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
-import androidx.core.view.updatePadding
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.activityViewModels
 import androidx.paging.PagingData
@@ -40,7 +39,6 @@ class DownloadingFragment : Fragment() {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         setupTransition(view)
         applyInsets {
-            binding.exceptionIconContainer.updatePadding(top = it.top)
             binding.recyclerView.applyContentInsets(it)
         }
         applyBackPressCallback()

diff --git a/app/src/main/java/dev/brahmkshatriya/echo/ui/login/LoginFragment.kt b/app/src/main/java/dev/brahmkshatriya/echo/ui/login/LoginFragment.kt
@@ -14,7 +14,6 @@ import android.webkit.WebView
 import android.webkit.WebViewClient
 import androidx.activity.OnBackPressedCallback
 import androidx.core.view.isVisible
-import androidx.core.view.updatePadding
 import androidx.core.widget.doAfterTextChanged
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
@@ -98,7 +97,6 @@ class LoginFragment : Fragment() {
     override fun onViewCreated(view: View, savedInstanceState: Bundle?) {
         setupTransition(view)
         applyInsets {
-            binding.iconContainer.updatePadding(top = it.top)
             binding.loginContainer.applyContentInsets(it)
             binding.loadingContainer.root.applyContentInsets(it)
         }

diff --git a/app/src/main/res/layout/fragment_download.xml b/app/src/main/res/layout/fragment_download.xml
@@ -24,13 +24,14 @@
                 android:id="@+id/exceptionIconContainer"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:layout_marginTop="64dp"
+                android:layout_marginHorizontal="24dp"
+                android:paddingTop="64dp"
                 android:layout_marginBottom="32dp"
-                android:layout_marginHorizontal="24dp">
+                android:paddingBottom="32dp">
 
                 <ImageView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
+                    android:layout_width="48dp"
+                    android:layout_height="48dp"
                     android:contentDescription="@string/album"
                     android:src="@drawable/art_download_for_offline" />
 

diff --git a/app/src/main/res/layout/fragment_downloading.xml b/app/src/main/res/layout/fragment_downloading.xml
@@ -24,13 +24,14 @@
                 android:id="@+id/exceptionIconContainer"
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
-                android:layout_marginTop="64dp"
+                android:layout_marginHorizontal="24dp"
+                android:paddingTop="64dp"
                 android:layout_marginBottom="32dp"
-                android:layout_marginHorizontal="24dp">
+                android:paddingBottom="32dp">
 
                 <ImageView
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
+                    android:layout_width="48dp"
+                    android:layout_height="48dp"
                     android:contentDescription="@string/album"
                     android:src="@drawable/art_downloading" />
 

diff --git a/app/src/main/res/layout/fragment_login.xml b/app/src/main/res/layout/fragment_login.xml
@@ -24,9 +24,9 @@
                 android:layout_width="match_parent"
                 android:layout_height="match_parent"
                 android:layout_marginHorizontal="24dp"
-                android:layout_marginTop="64dp"
+                android:paddingTop="64dp"
                 android:layout_marginBottom="32dp"
-                tools:layout_marginBottom="54dp">
+                android:paddingBottom="32dp">
 
                 <ImageView
                     android:id="@+id/extensionIcon"