Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #68: only try to link titles that are not redirect in LinkTitles-cli.php #69

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

bertrandgorge
Copy link
Contributor

No description provided.

@bovender
Copy link
Owner

bovender commented Oct 5, 2023

Thanks for your contribution. However, I must say that I am not so sure if this should be the default or only behavior. I for one prefer to have redirect pages being linked to -- often there is an alias for a given term, and I want that alias to be automatically linked on my Wikis, too.

Maybe we can make this configurable.

@bertrandgorge
Copy link
Contributor Author

Here the filter only applies to the list of pages that LinkTitle-cli.php candidate for modification when called for all pages. It does not change (if I did it right) the fact that we are going to link words in the current page to synonyms and redirects.

Now I'm not too sure about the fix to be honest, because it seems to have changed the behaviour of -s ?

@@ -369,6 +369,12 @@ page, but there may be a page title "Mg" which redirects to the page
"Magnesium". This settings prevents erroneous linking to very short titles by
setting a minimum length. You can adjust this setting to your liking.


$wgLinkTitlesMaximumTitleLength = 25;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, excellent idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants