Streamline error API #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TedDriggs
commented
Mar 4, 2022
| rules.entry(syscall) | ||
| .or_insert_with(Vec::new) | ||
| .push(rule); | ||
| rules.entry(syscall).or_insert_with(Vec::new).push(rule); |
There was a problem hiding this comment.
I have my editor set to auto-run rustfmt on save, so this change came about because of that. I did put the formatting update as its own first commit so it should be easy to remove if you prefer it be skipped.
There was a problem hiding this comment.
yes, unfortunately rustfmt makes a lot of decisions that make these kinds of statements uglier (while at the same time putting .unwrap() on newlines) so I end up just running it on diffs and manually taking the suggestions, which is not optimal.
The new names more closely match stdlib and popular library conventions.
The function is now precise in which error it can emit. Fixes #1
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposed API changes from #1.