Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fe markets stocks #411

Merged
merged 25 commits into from
Nov 25, 2024
Merged

Feature/fe markets stocks #411

merged 25 commits into from
Nov 25, 2024

Conversation

mahmutbugramert
Copy link
Contributor

@mahmutbugramert mahmutbugramert commented Nov 24, 2024 •
edited
Loading

This PR fixes #392

  • Add extra sections to Markets page.
  • Create post creation page.
  • Put created posts to database
  • Display created posts on Community page.

@mahmutbugramert
feat: add markets page data to seperate file.
9837f96
@mahmutbugramert
feat: change router for Stocks page
9617b98
@mahmutbugramert
feat: Delete redundant mock data
244a3c3
@mahmutbugramert
fix: Delete redundant mock data
73cb5db
@mahmutbugramert
fix: remove artificial timeout
de91c85
@mahmutbugramert
feat: add new data to mock.
377e9df
@mahmutbugramert
feat: add extra features to style of Market Page.
0044b21
@mahmutbugramert
fix: Correct path of Stocks page.
8e70590
@mahmutbugramert
fix: Correct path of Stocks page.
4daaffc
@mahmutbugramert
fix: refix the problem.
f65b2e3
@mahmutbugramert
feat: add navigation to create post page.
6c57886
@mahmutbugramert
feat: add create post page.
2aed447
@mahmutbugramert
feat: create a page for post creation.
6ca53bd
@mahmutbugramert
fix: remove redundant comments from markets page.
965deb6
@mahmutbugramert
feat: add style for post creation page.
e11d88f
@mahmutbugramert
fix: change mock posts' ids so that they are not same of the real post.
d54f5af
@mahmutbugramert
feat: Fetch and view real posts as well as mock posts.
b5b25c4
@mahmutbugramert
feat: Add mock tags. Publish posts.
eeb5425
@mahmutbugramert
feat: View real posts.
09186ec
@mahmutbugramert mahmutbugramert added the frontend issue related with frontend label Nov 24, 2024
@mahmutbugramert mahmutbugramert added this to the 451 - Milestone 2 milestone Nov 24, 2024
@mahmutbugramert mahmutbugramert self-assigned this Nov 24, 2024
@mahmutbugramert
Copy link
Contributor Author

I am not sure why package.json and package-lock.json are changed.

Halil-Ibrahim-Kasapoglu
Halil-Ibrahim-Kasapoglu requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@Halil-Ibrahim-Kasapoglu Halil-Ibrahim-Kasapoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dont use hard coded backend url, take a look at login page and how its uses environment variable. Otherwise our code can only run at either local or deployment environment (not both at the same time) without changin source code.

Halil-Ibrahim-Kasapoglu
Halil-Ibrahim-Kasapoglu requested changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@Halil-Ibrahim-Kasapoglu Halil-Ibrahim-Kasapoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have seen that at some parts you have added css objects using hardcoded colors. Do not use something we dont have in our color palette otherwise you will broke dark mode compat. Take a look at index.css to see more

@mahmutbugramert
Copy link
Contributor Author

Thank you for your feedback Halil. I made the changes required. It is open to review again @Halil-Ibrahim-Kasapoglu.

Halil-Ibrahim-Kasapoglu
Halil-Ibrahim-Kasapoglu approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@Halil-Ibrahim-Kasapoglu Halil-Ibrahim-Kasapoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its all good now

frontend/src/styles/community/CreatePostPage.css Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Halil-Ibrahim-Kasapoglu Halil-Ibrahim-Kasapoglu Halil-Ibrahim-Kasapoglu approved these changes

@danzio19 danzio19 Awaiting requested review from danzio19

Assignees

@mahmutbugramert mahmutbugramert

Labels
frontend issue related with frontend
Projects
None yet
Milestone
451 - Milestone 2
Development

Successfully merging this pull request may close these issues.
2 participants
@mahmutbugramert @Halil-Ibrahim-Kasapoglu