fix(components): fix dropdown not disappearing after selection (#508)

botpress · Jul 11, 2022 · bf999be · bf999be
1 parent 143d21a
commit bf999be
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 8 deletions.
diff --git a/packages/webchat/components/package.json b/packages/webchat/components/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@botpress/messaging-components",
-  "version": "0.4.0",
+  "version": "0.4.2",
   "main": "dist/index.js",
   "types": "dist/index.d.ts",
   "source": "src/index.tsx",

diff --git a/packages/webchat/components/src/renderer/choice.tsx b/packages/webchat/components/src/renderer/choice.tsx
@@ -53,7 +53,7 @@ export class SingleChoice extends Component<MessageTypeHandlerProps<'single-choi
     return (
       <div>
         {this.props.text}
-        {shouldDisplay && <Prepend keyboard={keyboard}>{this.props.children}</Prepend>}
+        {shouldDisplay && <Prepend keyboard={keyboard} />}
       </div>
     )
   }

diff --git a/packages/webchat/components/src/renderer/dropdown.tsx b/packages/webchat/components/src/renderer/dropdown.tsx
@@ -67,7 +67,7 @@ export const Dropdown = ({
           )}
         </div>
 
-        {displayInKeyboard && (
+        {buttonText && (
           <button className="bpw-button" onClick={sendChoice}>
             {buttonText}
           </button>
@@ -85,8 +85,13 @@ export const Dropdown = ({
     text = <p>{message}</p>
   }
 
-  if (displayInKeyboard) {
-    return <Prepend keyboard={renderSelect(true)}>{text}</Prepend>
+  if (shouldDisplay && displayInKeyboard) {
+    return (
+      <div>
+        {text}
+        <Prepend keyboard={renderSelect(true)} />
+      </div>
+    )
   }
 
   return (

diff --git a/packages/webchat/webchat/package.json b/packages/webchat/webchat/package.json
@@ -38,7 +38,7 @@
   },
   "dependencies": {
     "@blueprintjs/core": "^3.54.0",
-    "@botpress/messaging-components": "0.4.0",
+    "@botpress/messaging-components": "0.4.2",
     "@botpress/messaging-socket": "1.2.0",
     "@formatjs/intl-pluralrules": "^4.3.3",
     "@formatjs/intl-utils": "^3.8.4",

diff --git a/yarn.lock b/yarn.lock
@@ -2666,7 +2666,7 @@ __metadata:
   languageName: unknown
   linkType: soft
 
-"@botpress/[email protected].0, @botpress/messaging-components@workspace:packages/webchat/components":
+"@botpress/[email protected].2, @botpress/messaging-components@workspace:packages/webchat/components":
   version: 0.0.0-use.local
   resolution: "@botpress/messaging-components@workspace:packages/webchat/components"
   dependencies:
@@ -3268,7 +3268,7 @@ __metadata:
   resolution: "@botpress/webchat@workspace:packages/webchat/webchat"
   dependencies:
     "@blueprintjs/core": ^3.54.0
-    "@botpress/messaging-components": 0.4.0
+    "@botpress/messaging-components": 0.4.2
     "@botpress/messaging-socket": 1.2.0
     "@botpress/testing": 1.0.0
     "@formatjs/intl-pluralrules": ^4.3.3