Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Laravel 5.8 #80

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Upgrade to Laravel 5.8 #80

wants to merge 5 commits into from

Conversation

etdte
Copy link

@etdte etdte commented Mar 11, 2019

This PR will upgrade the studio to current Laravel's release. Creating draft PR, because now studio-addons is not compatible with L5.8

laravel-shift and others added 5 commits March 11, 2019 06:57
@laravel-shift
Shift configuration
6bd31f3
@laravel-shift
Shift deprecated helpers
ebb9420 
Laravel recommends using the `Str` and `Arr` class methods directly instead of the respective helper functions. These helper functions are [deprecated in Laravel 5.8][1] and will be removed in a future version.

[1]: laravel/framework#26898
@laravel-shift
Shift Laravel dependencies
39d4a1a
Update app.php config file to Laravel 5.8 version.
4639f67
Bump botman/studio-addons version.
1bce95d
@etdte
Copy link
Author

etdte commented Mar 11, 2019

Hey, @christophrumpel. Once botman/studio-addons 1.5 will become available on Packagist, this PR is ready to go. I see errors from StyleCI, and afaik, they can be resolved in 2 clicks, so, I wouldn't spend time to fix it manually, that's just unreasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etdte @laravel-shift