feat: Add skip_reset bmi270_init, preventing soft reset during init
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -150,7 +150,7 @@ extern "C" { | |||
| * @retval 0 -> Success | |||
| * @retval < 0 -> Fail | |||
| */ | |||
| int8_t bmi270_init(struct bmi2_dev *dev); | |||
| int8_t bmi270_init(struct bmi2_dev *dev, uint8_t skip_reset); | |||
There was a problem hiding this comment.
IMO you shouldn't modify the API, it will break all examples, and also all applications already using it, and just updating the driver.
Instead add a new API, bmi270_init_opt or smth else then:
int8_t bmi270_init(struct bmi2_dev *dev)
{
return bmi270_init_opt(dev, false);
}
int8_t bmi270_init_opt(struct bmi2_dev *dev, uint8_t skip_reset) {
....
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
skip_resetoption tobmi270_init. Useful when waking up from sleep and the IMU has already initialized. Preventing the soft reset lets us read IMU regs to get activity data (such as step count) while we were asleep.