-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simultaneous support for Python 2 and Python 3 #46
base: develop
Are you sure you want to change the base?
Conversation
Were you able to make any more progress with this? Are you running your regressions under python 3? I see in collect_and_upload_logs.py row 182 they're dealing with it as a text file. Opening that file as binary, then Similarly in process_xml_file() row 103. Neither will get as far as the |
I haven't looked at this in a very long time, but I believe that issue is still there. I'm still using python 2 for the regression runs. |
I've made the changes to follow the program through in both version of python. This Fixes #43.
Please don't merge yet, there are two known defects.
Different results
The windows version shows slightly different results on windows. Looking at the develop results the
teeks99-test-py23-p2-w
andteeks99-test-py23-p3-w
they are the same except for thebuild
results which are missing for the python 3 version.Different output
On linux (running python 3.5), I get an exception running through the log for regex. Running with Python 3 the file
results/boost/bin.v2/libs/regex/example/icu_example.test/gcc-8~c++2a/debug/threading-multi/visibility-hidden/test_log.xml
contains:whereas the python 2 version contains:
The difference on the
£198.12
vs.<C2><A3>198.12
causes aUnicodeDecodeError: 'ascii' codec can't decode byte 0xc2 in position 1803: ordinal not in range(128)
. Any ideas what could be causing the differences in the xml files? Something about the environment that runs the tests?