Avoid deprecated bind placeholders in global namespace #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't this PR duplicate #91 (not just relates to)? Granted, that PR does more than just silence the warnings. |
|
Well, it does, but I assumed the PR #91 is never gonna be merged as it is a mixture of unrelated changes, actual fixes with code tidying up and formatting. So, to increase chances for the fix being merged, I submitted this focused PR. |
|
Thanks for the PR. Since only .cpp files are affected, I would prefer if 'using namespace boost::placehoders' were at the top level. Having this twice inside specific code blocks does not seem to be useful. Would that solve the problem? |
|
@vprus I refactored the PR as you suggest. Seems fine. |
This fixes numerous compilation warnings:
note: #pragma message:
The practice of declaring the Bind placeholders (_1, _2, ...)
in the global namespace is deprecated.
Please use <boost/bind/bind.hpp> + using namespace boost::placeholders,
or define BOOST_BIND_GLOBAL_PLACEHOLDERS to retain the current behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes numerous yet annoying compilation warnings:
This is somewhat related to PR #91
Apart from obscuring the output of compilation of libraries using Boost.Test, it may be troublesome on CI builds. On many CI services every line of log counts and if log dumps become too long,
builds are terminated.