Feat: 지도 탭 캐러셀 구현 + Extension 분리 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyukyung
requested review from
loinsir and
chopmozzi
and removed request for
loinsir
loinsir
reviewed
Nov 20, 2023
Comment on lines
+12
to
+33
| static func createCarouselLayout(groupWidthDimension: CGFloat, | ||
| groupHeightDimension: CGFloat, | ||
| maximumZoomScale: CGFloat, | ||
| minimumZoomScale: CGFloat) -> UICollectionViewLayout { | ||
| let itemSize = NSCollectionLayoutSize(widthDimension: .fractionalWidth(1), | ||
| heightDimension: .fractionalHeight(1)) | ||
| let item = NSCollectionLayoutItem(layoutSize: itemSize) | ||
| let groupSize = NSCollectionLayoutSize(widthDimension: .fractionalWidth(groupWidthDimension), | ||
| heightDimension: .fractionalHeight(groupHeightDimension)) | ||
| let group = NSCollectionLayoutGroup.horizontal(layoutSize: groupSize, subitems: [item]) | ||
| let section = NSCollectionLayoutSection(group: group) | ||
| section.orthogonalScrollingBehavior = .groupPagingCentered | ||
| section.visibleItemsInvalidationHandler = { items, offset, environment in | ||
| let containerWidth = environment.container.contentSize.width | ||
| items.forEach { item in | ||
| let distanceFromCenter = abs((item.center.x - offset.x) - environment.container.contentSize.width / 2.0) | ||
| let scale = max(maximumZoomScale - (distanceFromCenter / containerWidth), minimumZoomScale) | ||
| item.transform = CGAffineTransform(scaleX: scale, y: scale) | ||
| } | ||
| } | ||
| return UICollectionViewCompositionalLayout(section: section) | ||
| } |
There was a problem hiding this comment.
고생하셨네요. 추후 홈 뷰에 쓰인 코드도 이걸 사용하도록 바꿔야겠어요
loinsir
approved these changes
Nov 20, 2023
chopmozzi
approved these changes
Nov 20, 2023
Comment on lines
+80
to
+83
| [mapView, searchButton, currentLocationButton, uploadButton, carouselCollectionView].forEach { | ||
| view.addSubview($0) | ||
| $0.translatesAutoresizingMaskIntoConstraints = false | ||
| } |
There was a problem hiding this comment.
결국 addSubviews는 안 쓰기로 합의가 된 것일까요 ?ㅅ?
| } | ||
|
|
||
| required init?(coder: NSCoder) { | ||
| super.init(coder: coder) |
There was a problem hiding this comment.
여기도 backgroundColor = .white들어가야 하는거 아닌가요? 그냥 앱이 종료되는 것만 막는 장치일까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
해당 pr에서 작업한 내역을 적어주세요.
📌 변경 사항
변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.
📸 ScreenShot
작동, 구현화면
Linked Issue
close #26