chore: 지도에서 재생 넘어갔을 때의 삭제 #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loinsir
reviewed
Dec 13, 2023
| var selectedTag: String? | ||
|
|
||
| private var isFetchReqeust: Bool = false | ||
|
|
||
| private var currentPage: Int = 1 | ||
|
|
||
| private var playbackVideoInfos: [Models.PlaybackInfo] = [] | ||
|
|
||
| // MARK: - UseCase Load Video List | ||
|
|
||
| func displayVideoList() -> Task<Bool, Never> { |
There was a problem hiding this comment.
지웅님 이거 제가 광현님 답변 공유드린것처럼 Task 리턴이 아니라 메서드 자체를 async로 선언하시고 사용하는 뷰컨쪽에서 Task로 감싸서 사용하도록 변경해주세요~!
There was a problem hiding this comment.
넵 안그래도 테스트 수정 하면서 하려구요~~~ delete는 해놨는데 다른 부분은 아직 못했어요 ㅜ
loinsir
approved these changes
Dec 13, 2023
|
지웅님 이건 별건 아니구 addPeriodicTimer에 1초로 되어있는거 더 작게 수정해주실 수 있나요? 1초도 괜찮긴 한데 유튜브 같은거 보면 재생바가 1초보다 더 작게 움직이더라구요 ㅎㅎ 한 0.2?0.3? 초로 가능하실까용 |
anyukyung
reviewed
Dec 14, 2023
| @@ -294,8 +365,7 @@ final class PlaybackInteractor: PlaybackBusinessLogic, PlaybackDataStore { | |||
| isFetchReqeust = true | |||
| var page: Int = 0 | |||
| if parentView != .home { | |||
| guard let posts else { return false } | |||
| page = posts.count / 15 + 1 | |||
| page = playbackVideoInfos.count / 15 + 1 | |||
There was a problem hiding this comment.
요 15 매직넘버 페이지네이션할때 오는 Post 개수인거죠 ?? PlaybackModel에 따로 상수로 빼면 좋을 것 같아요!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🚀 PR 요약
원래 지도에서 재생 넘어갔을 때 동영상을 삭제하면 무한스크롤을 위해 만들어둔 더미 셀에 영향을 줘 해당 부분 영향 안 가게 수정했습니다.
📌 변경 사항
재생화면에서 지도 화면 넘어갔을 때 삭제한거 반영안되길래 fetchPosts추가 해놨습니다. 원복해야 하면 말씀해주세요.
Linked Issue
close #325