Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: EditProfile 테스트코드 작성 #327

Merged
merged 4 commits into from
Dec 13, 2023
Merged

test: EditProfile 테스트코드 작성 #327

merged 4 commits into from
Dec 13, 2023

Conversation

loinsir
Copy link
Collaborator

@loinsir loinsir commented Dec 13, 2023

🧑‍🚀 PR 요약

  • EditProfile 테스트 코드 작성

예외 케이스가 너어어어무 많아서 힘든 테스트 코드 였습니다...

📌 변경 사항

  • ViewController 테스트는 작성하지 않았습니다.

Linked Issue

close #317

@loinsir loinsir self-assigned this Dec 13, 2023
anyukyung
anyukyung approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@anyukyung anyukyung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

예상했던대로 프로필 수정은 케이스가 많군요 ㅠㅠㅠ
고생하셨습니다 🎀

chopmozzi
chopmozzi approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

경악할 수준의 테스트 케이스네요.. .고생하셨습니다.

@loinsir loinsir merged commit 616829c into iOS/dev Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anyukyung anyukyung anyukyung approved these changes

@chopmozzi chopmozzi chopmozzi approved these changes

Assignees

@loinsir loinsir

Labels
🍎 iOS 🧪 test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@loinsir @chopmozzi @anyukyung