Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LOButton, LOTextField 컴포넌트 생성, SignUpViewController 뷰 구현 #14

Merged
merged 6 commits into from
Nov 15, 2023

Conversation

anyukyung
Copy link
Member

@anyukyung anyukyung commented Nov 14, 2023

🧑‍🚀 PR 요약

해당 pr에서 작업한 내역을 적어주세요.

  • LOButton 컴포넌트 생성
  • LOTextField 컴포넌트 생성
  • SignUpViewController 뷰 구현
  • 아래와 같은 형태로 사용 -> 일단 고민하면서 구현해봤는데 더 좋은 방법있으면 리뷰 plz
    private lazy var nicknameTextfield: LOTextField = {
        let textField = LOTextField()
        textField.placeholder = "닉네임을 입력해주세요."
        textField.addTarget(self, action: #selector(setUpTextFieldState(_:)), for: .editingChanged)
        return textField
    }()

    private let checkDuplicateNicknameButton: LOButton = {
        let button = LOButton(style: .basic)
        button.isEnabled = false
        button.setTitle("중복확인", for: .normal)
        return button
    }()
  • 닉네임 validation 부분은 따로 분리할까 고민함.. -> 일단 확신이 안서서 분리안함
    • Interactor로 빼야하나.. 근데 또 비즈니스 로직은 아닌것같은데 싶음
    • 좋은 의견 부탁드립니당.. 뭔가 다시 미션하는 느낌이 들었네요

📌 변경 사항

변경사항 및 주의 사항 (모듈 설치 등)을 적어주세요.

�N/A

📸 ScreenShot

작동, 구현화면

RPReplay_Final1699990123.MP4

Linked Issue

close #7

@anyukyung anyukyung added this to the iOS milestone Nov 14, 2023
@anyukyung anyukyung self-assigned this Nov 14, 2023
@anyukyung anyukyung linked an issue Nov 14, 2023 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~~

Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

프로토콜관련해서 좀 더 얘기를 나눠보아용

Copy link
Collaborator

@loinsir loinsir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VIP 구조로 바꾸신 것 완전 대박인데요?! 테스트 하기 쉬워진 구조가 되었네요!

Comment on lines 108 to 110
nicknameAlertLabel.isHidden = response.canCheckDuplication
checkDuplicateNicknameButton.isEnabled = response.canCheckDuplication
nicknameAlertLabel.text = response.alertDescription
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@chopmozzi chopmozzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@anyukyung anyukyung merged commit 236fc86 into iOS/dev Nov 15, 2023
1 check passed
@anyukyung anyukyung deleted the iOS/feat#7 branch January 10, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: 회원가입 정보 입력 뷰
3 participants