♻️ Refactor: final 키워드 추가, shared 네이밍 수정, 프로토콜 익스텐션으로 분리

boostcampwm2023 · Nov 15, 2023 · 79a2547 · 79a2547
1 parent c534805
commit 79a2547
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 16 deletions.
diff --git a/iOS/Layover/Layover/Scenes/SignUpViewController.swift b/iOS/Layover/Layover/Scenes/SignUpViewController.swift
@@ -13,8 +13,8 @@ protocol SignUpDisplayLogic: AnyObject {
     func displayNickanmeDuplication()
 }
 
-final class SignUpViewController: UIViewController, SignUpDisplayLogic {
-
+final class SignUpViewController: UIViewController {
+    
     // MARK: - UI Components
 
     private let titleLabel: UILabel = {
@@ -60,7 +60,7 @@ final class SignUpViewController: UIViewController, SignUpDisplayLogic {
 
     override func viewDidLoad() {
         super.viewDidLoad()
-        SignUpConfigurator.sharedInstance.configure(self)
+        SignUpConfigurator.shared.configure(self)
         setUI()
 
         // TODO: Base ViewController 로직으로 분리
@@ -104,16 +104,6 @@ final class SignUpViewController: UIViewController, SignUpDisplayLogic {
 
     // MARK: - Custom Method
 
-    func displayNicknameValidation(response: SignUpModels.ValidateNickname.ViewModel) {
-        nicknameAlertLabel.isHidden = response.canCheckDuplication
-        checkDuplicateNicknameButton.isEnabled = response.canCheckDuplication
-        nicknameAlertLabel.text = response.alertDescription
-    }
-
-    func displayNickanmeDuplication() {
-
-    }
-
     private func addTapGesture() {
         let tapGesture = UITapGestureRecognizer(target: self, action: #selector(hideKeyboard(_:)))
         view.addGestureRecognizer(tapGesture)
@@ -127,5 +117,16 @@ final class SignUpViewController: UIViewController, SignUpDisplayLogic {
     @objc private func hideKeyboard(_ sender: Any) {
         view.endEditing(true)
     }
+}
+
+extension SignUpViewController: SignUpDisplayLogic {
+    func displayNicknameValidation(response: SignUpModels.ValidateNickname.ViewModel) {
+        nicknameAlertLabel.isHidden = response.canCheckDuplication
+        checkDuplicateNicknameButton.isEnabled = response.canCheckDuplication
+        nicknameAlertLabel.text = response.alertDescription
+    }
 
+    func displayNickanmeDuplication() {
+
+    }
 }
diff --git a/iOS/Layover/Layover/Scenes/SingUpScene/SignUpConfigurator.swift b/iOS/Layover/Layover/Scenes/SingUpScene/SignUpConfigurator.swift
@@ -11,7 +11,7 @@ import Foundation
 final class SignUpConfigurator: Configurator {
     typealias T = SignUpViewController
 
-    static let sharedInstance = SignUpConfigurator()
+    static let shared = SignUpConfigurator()
 
     private init() { }
 

diff --git a/iOS/Layover/Layover/Scenes/SingUpScene/SignUpInteractor.swift b/iOS/Layover/Layover/Scenes/SingUpScene/SignUpInteractor.swift
@@ -14,7 +14,7 @@ protocol SignUpBusinessLogic {
 
 protocol SignUpDataStore { }
 
-class SignUpInteractor: SignUpBusinessLogic, SignUpDataStore {
+final class SignUpInteractor: SignUpBusinessLogic, SignUpDataStore {
 
     // MARK: - Properties
 

diff --git a/iOS/Layover/Layover/Scenes/SingUpScene/SignUpPresenter.swift b/iOS/Layover/Layover/Scenes/SingUpScene/SignUpPresenter.swift
@@ -12,7 +12,7 @@ protocol SignUpPresentationLogic {
     func presentNicknameValidation(with response: SignUpModels.ValidateNickname.Response)
 }
 
-class SignUpPresenter: SignUpPresentationLogic {
+final class SignUpPresenter: SignUpPresentationLogic {
 
     // MARK: - Properties