Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE/#497] 리팩토링 #497 #498

Merged
merged 5 commits into from
Dec 11, 2023
Merged

[BE/#497] 리팩토링 #497 #498

merged 5 commits into from
Dec 11, 2023

Conversation

koomin1227
Copy link
Member

이슈

체크리스트

  • 폴더 구조 변경
  • 코드 스타일 변경

고민한 내용

  • 무슨 이유로 어떻게 코드를 변경했는지
  • 어떤 부분에 리뷰어가 집중해야 하는지
  • 기술적 고민

스크린샷

@koomin1227 koomin1227 self-assigned this Dec 11, 2023
@namewhat99 namewhat99 changed the title Be refactoring #497 [BE/#497] 리팩토링 #497 Dec 11, 2023
Comment on lines -141 to -162
async changeImages(postId: number, images: string[]) {
try {
await this.postImageRepository.delete({ post_id: postId });
for (const img of images) {
await this.postImageRepository.save({
post_id: postId,
image_url: img,
});
}
} catch {
throw new HttpException('서버 오류입니다.', 500);
}
}

async changeExceptImages(postId: number, updatePostDto: UpdatePostDto) {
try {
await this.postRepository.update({ id: postId }, updatePostDto);
} catch (e) {
throw new HttpException('서버 오류입니다.', 500);
}
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그냥 지워버린줄 알았는데 안쓰는거라니 다행임다~

@namewhat99 namewhat99 merged commit 60eb6a1 into BE Dec 11, 2023
1 check passed
@namewhat99 namewhat99 deleted the BE-Refactoring-#497 branch December 11, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants