Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BE/#475] 채팅 강제 disconnect 처리 #480

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Conversation

namewhat99
Copy link
Collaborator

이슈

체크리스트

  • 만약 다른 방에 join 했는데 소켓이 남아있으면 기존 소켓을 disconnect

@namewhat99 namewhat99 added review code-review BE BE 관련 chatting 채팅 labels Dec 11, 2023
@namewhat99 namewhat99 self-assigned this Dec 11, 2023
@namewhat99 namewhat99 changed the title [BE/$475] 채팅 강제 disconnect 처리 [BE/#475] 채팅 강제 disconnect 처리 Dec 11, 2023
@namewhat99 namewhat99 closed this Dec 11, 2023
@namewhat99 namewhat99 reopened this Dec 11, 2023
@namewhat99 namewhat99 closed this Dec 11, 2023
@namewhat99 namewhat99 deleted the BE-disconnectSocket-#475 branch December 11, 2023 09:04
@namewhat99 namewhat99 restored the BE-disconnectSocket-#475 branch December 11, 2023 09:05
@namewhat99 namewhat99 reopened this Dec 11, 2023
Copy link
Member

@koomin1227 koomin1227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좀 더 엄격하게 방관리가 가능할거 같네요 좋습니다.

@@ -21,6 +21,7 @@ interface ChatWebSocket extends WebSocket {
})
export class ChatsGateway implements OnGatewayConnection, OnGatewayDisconnect {
@WebSocketServer() server: Server;
private users = new Map<string, ChatWebSocket>();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저들을 따로 관리 하면 좀 더 효율적으로 관리가 가능 하겠네요

@namewhat99 namewhat99 merged commit 59cb1f6 into BE Dec 11, 2023
1 check passed
@namewhat99 namewhat99 deleted the BE-disconnectSocket-#475 branch December 11, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BE BE 관련 chatting 채팅 review code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants