Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE/#264] 채팅 내역 응답 API #266

Merged
merged 3 commits into from
Dec 3, 2023
Merged

[BE/#264] 채팅 내역 응답 API #266

merged 3 commits into from
Dec 3, 2023

Conversation

namewhat99
Copy link
Collaborator

이슈

체크리스트

  • 채팅 내역 + postId 응답하는 API 구현

고민한 내용

  • url 로 채팅 내역에 접근할 수 있으므로 error 처리 필요했음

스크린샷

@namewhat99 namewhat99 added review code-review BE BE 관련 chatting 채팅 labels Dec 3, 2023
@namewhat99 namewhat99 requested a review from koomin1227 December 3, 2023 06:01
@namewhat99 namewhat99 self-assigned this Dec 3, 2023
koomin1227
koomin1227 approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@koomin1227 koomin1227 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

좋습니다

BE/src/chat/chat.service.ts
@@ -91,19 +91,19 @@ export class ChatService {
relations: ['chats'],
});

this.checkAuth(room, userId);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

권한 확인 좋습니다~!

@koomin1227 koomin1227 merged commit c6eb04c into BE Dec 3, 2023
1 check passed
@koomin1227 koomin1227 deleted the BE-chatList-#264 branch December 3, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koomin1227 koomin1227 koomin1227 approved these changes

Assignees

@namewhat99 namewhat99

Labels
BE BE 관련 chatting 채팅 review code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@namewhat99 @koomin1227