부스트캠프 6기 iOS 코드 리뷰어 지원 #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(boostcamp-2020#25 boostcamp-2020#26) ActivityScene TotalView 연결 및 Date PickerView 구현
(boostcamp-2020#97) feat: running split scene 구현
(boostcamp-2020#91) feat: Location accuracy에 따른 값 전송 유무 로직 추가
(boostcamp-2020#88) Motion Type에 따라 자동으로 러닝을 일시정지 및 재시작한다
…e <--> EditProfileScene)
(boostcamp-2020#191) fix: 다크모드 및 라이트모드 toggle시 annotation이 바뀌는 버그 수정
…/179 (boostcamp-2020#136, 161, 179) 및 코드 컨벤셔닝
fix: Calorie 누적 오류 Int -> Double
(boostcamp-2020#196)fix: pausedWorkout 사운드 문제
(boostcamp-2020#198) feat: split detail 데이터 바인딩
| let imageData = try Data(contentsOf: fileURL) | ||
| return imageData | ||
| } catch { | ||
| print(error) |
There was a problem hiding this comment.
에러가 발생하는 경우에 처리 로직이 필요하지 않을까요?
| do { | ||
| try imageData.write(to: url) | ||
| } catch { | ||
| print(error) |
There was a problem hiding this comment.
에러가 발생하는 경우에 처리 로직이 필요하지 않을까요?
| guard let hourMinSec = self.hourMinSec else { return "알수없는 시간대" } | ||
| switch hourMinSec.hour { | ||
| case 22 ... 24, 0 ..< 3: | ||
| return "야간" |
There was a problem hiding this comment.
localization을 도입하여 다양한 언어를 대응해보는건 어떨까요?
| tabBarController.tabBar.tintColor = TabBarPage.selectColor | ||
| tabBarController.tabBar.unselectedItemTintColor = TabBarPage.unselectColor | ||
| tabBarController.tabBar.barTintColor = .systemBackground | ||
| viewControllers[0].tabBarItem = UITabBarItem(title: nil, image: UIImage(named: "activity4"), tag: 0) |
There was a problem hiding this comment.
배열에 직접 접근하면 Crash가 발생 할 수 있으니 범위 체크를 하는건 어떨까요?
| case .speed: | ||
| return "속도" | ||
| case .none: | ||
| return "목표 설정" |
There was a problem hiding this comment.
이 부분도 localization을 공부하여 적용해보는건 어떨까요?
|
|
||
| timer = Timer(fire: Date(), interval: 1.0 / 100.0, repeats: true, | ||
| block: { _ in | ||
| if let data = self.motion.deviceMotion { |
There was a problem hiding this comment.
코드가 너무 깊어지는데 외부에서 블럭을 생성하여 넣어주는식으로 변경하는건 어떨까요?
| } | ||
| .store(in: &cancellables) | ||
|
|
||
| // locationProvider.locationSubject |
| } | ||
|
|
||
| deinit { | ||
| print("[Memory \(Date())] 🌙ViewModel⭐️ \(Self.self) deallocated.") |
There was a problem hiding this comment.
print로 로그를 찍는것 보다 ConsoleLogger를 만들고 거기서 처리하는건 어떨까요?
ConsoleLogger를 만들면 이점은
- print로 찍는 경우 많은 로그가 쌓이는 경우에 제대로 노출이 안되는 문제가 있음 (serial Queue로 관리 필요)
- AppStore version에서는 무시하도록 처리함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.