Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new theme: "minimal" #408

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

new theme: "minimal" #408

wants to merge 40 commits into from

Conversation

JonathanReeve
Copy link
Contributor

I wanted to simplify the buddypress-docs UI a little bit, so I put these changes into a new theme. I added an admin section "Appearance" and a setting "theme," which now has two options: Default and Minimal. Selecting "minimal" engages the "minimal" theme, which has these features:

  • No tabs. An extreme change, perhaps, but I figure they're unnecessary. While on a group docs page, it's not necessary to have a link to "all docs" (this is taken care of by the site-wide docs page), nor is it necessary to show the group's name (i.e. Example Group's Docs). Besides, going to "all docs" from a group page is confusing to the user, who expects to remain in the group page. On the "all docs" listing, a user's "created by me" and "edited by me" docs are handled by that user's profile page.
  • No tables. Tables are replaced with a cleaner, paragraph-style display. This eliminates redundancy with lines where the "created date" and "last modified date" are the same.

Screenshot of the revamped doc listing view:
screen shot 2014-05-27 at 2 11 20 pm

@BoweFrankema
Copy link

Just wanted to say that this is some amazing work. Very useful and welcome for those needing simplified doc listings.

@JonathanReeve
Copy link
Contributor Author

Thanks! I hope it'll be useful for others. Let me know if there's anything that doesn't work as expected.

@boonebgorges
Copy link
Owner

@JonathanReeve - This is really beautiful. Thanks for your work on it. I'm going to have a close look at it in the upcoming weeks.

@dcavins
Copy link
Collaborator

dcavins commented Jun 17, 2014

Hi Boone-

This reminds me that I was working on some bbPress theming and realized that its "table" view is actually divs (I also saw that mercime did some nice work to help make the default theme responsive). I wondered if it would make sense for BP-Docs to move toward using some of the same layout elements and class names as bbPress, so that themers would be working on two views at one time (if they chose). I'd be happy to help develop a new set of templates that moves in that direction as well, if you think it would be useful. (I also suspect that a bbPress-like conglomeration of divs would be simpler to re-theme.)

@JonathanReeve
Copy link
Contributor Author

@boonebgorges, I merged my fork with ver. 1.8 if you want to give it another look.

@boonebgorges
Copy link
Owner

@JonathanReeve Excellent - thanks very much. I haven't forgotten about this, but I'm in the middle of another, potentially conflicting, project related to BuddyPress Docs (https://github.com/boonebgorges/buddypress-docs/tree/folders) I want to get that in a reasonably stable place before I start thinking seriously about how your very nice improvements fit in with those changes.

putting this on a different branch so it doesn't conflict with my
pull request for the minimal theme.

This reverts commit 00a4eae.
@mln83
Copy link

mln83 commented Nov 12, 2015

@JonathanReeve I just stumbled across your fork ''minimal'' theme and it falls very much in line with what I have been thinking about. I am not a WordPress programmer but I just want to say great job to both you, @boonebgorges and @dcavins (#466). I hope the "minimal" theme and table-ss overview (pardon the pun) will make it into BuddyPress Docs 1.9. Best of luck!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants