Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

[WIP] Shipper uses Helm v3 #280

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[WIP] Shipper uses Helm v3 #280

wants to merge 1 commit into from

Conversation

osdrv
Copy link
Contributor

@osdrv osdrv commented Feb 3, 2020

This commit bumps Helm rendering engine version to v3 from v2. The
new version is a major update and therefore is partially incompatible
with the former head version. This commit brings the version to the
latest stable one. Refs #228.

As kustomize is now a part of Helm distribution and helm/helm#7259 is hopefully landing in 3.x, marking it as refs #101.

This change needs a careful testing cycle. As far as it went out of the release plan, no need to get it merged immediately.

Signed-off-by: Oleg Sidorov [email protected]

@osdrv osdrv added the enhancement New feature or request label Feb 3, 2020
@osdrv osdrv self-assigned this Feb 3, 2020
@osdrv osdrv changed the title Shipper uses Helm v3 [WIP] Shipper uses Helm v3 Feb 4, 2020
This commit bumps Helm rendering engine version to v3 from v2. The
new verison is a major update and therefore is partially incompatible
with the former head version. This commit brings the version to the
latest stable one.

Signed-off-by: Oleg Sidorov <[email protected]>
@osdrv
Copy link
Contributor Author

osdrv commented Feb 6, 2020

Overall, I'm quite positive on moving on with this change. Our preliminary tests indicate the baseline functionality works just fine.

@osdrv osdrv added this to the release-0.10 milestone Feb 26, 2020
@kanatohodets
Copy link
Contributor

The post render stuff is quite interesting! It's encouraging that the interface is pretty generic (PostRenderer.Run takes a byte slice and returns a byte slice), so it seems like a great way to think about using Kustomize or any other layering patch implementation to let people tune charts just in time.

However, reading the implementation, it looks the hook was implemented as part of the CLI command (https://github.com/helm/helm/blob/66292e5e240dd9ab3d28415d9b3946ca8efc521e/pkg/action/install.go#L572).

In the long run I think it'd be great to delegate the business of rendering and installing manifests, but looking around action.go linked above I think it'd be a little tricky to do so and maintain lifecycle control like we have now (clear split between rendering and installation, for example). What do you think?

@osdrv
Copy link
Contributor Author

osdrv commented Mar 24, 2020

@kanatohodets The current progress of kustomize adoption in Helm seems to be at the very early stage and I'm quite sure it might transform into something completely different-looking in the future. By now, we are aiming to commit a transition towards Helm v3 and ensure Shipper works stable. Opening this opportunity of building in some kustomize-based rendering sub-pipeline is not the major goal of this PR but clearly an implication on some future potential use. From that perspective, I see no concerns in switching and as you can see I have no proposal for the user-facing handle to make rendering customization work :-)

@Svisstack
Copy link

This is aborted?

@hihilla
Copy link
Contributor

hihilla commented Feb 25, 2021

@Svisstack not yet

@jpuskar
Copy link

jpuskar commented Jul 9, 2021

Just wondering if this is still active.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants