fix-bug: missing-pick-sentences #33
Conversation
|
@guojiangwei2 Hi, as you can see some tests failed for your changes. Please try to make changes so the tests will be green and also please add new tests for your cases to be sure it works. Thanks |
|
@miso-belica This is because the Travis-CI runner for this project is broken. There are packages that are no longer available and Bookie doesn't build. It has nothing to do with the code that was committed. Unfortunately the last time I tried to get things working it created a cascade of errors and package dependencies that didn't pan out. I could use some help in getting the Travis-CI working again. |
|
@craigmaloney Jop, I can see that for Python 2.6/3.2 there is some problem not related for tests, but other versions were running and I can see failed tests. Or do you think it's also because of some missing/broken packages and I am missing something there? I think I can try to fix it and add more Python versions in my spare time :) What did you try? Can you please provide some more info if you remember/have any? |
|
It's a combination of things. This would be best added to a separate ticket though. :) |
|
OK, it looks like the test runner is fixed. (Thanks, @miso-belica). Please merge and verify the tests are passing and re-push. Thanks! |
| @@ -193,6 +191,7 @@ def clean_document(node): | |||
| logger.debug("Dropping <%s>, it's insignificant", n.tag) | |||
| to_drop.append(n) | |||
|
|
|||
| """ modified by guojw | |||
There was a problem hiding this comment.
Not sure why this is being commented out. prefer to have the reasoning behind the commenting out rather than just a name.
| @@ -16,3 +16,4 @@ lib/ | |||
| local/ | |||
| man/ | |||
| share/ | |||
| .idea/ | |||
There was a problem hiding this comment.
please remove this directory.
| MIN_HIT_LENTH = 25 | ||
| # guojw | ||
| # MIN_HIT_LENTH = 25 | ||
| MIN_HIT_LENTH = 1 |
There was a problem hiding this comment.
What's the reasoning behind changing this to 1?
issue:32