Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate weather/env-effects (rain, clouds, haze, etc.) #312

Open
kb173 opened this issue Mar 15, 2023 · 1 comment
Open

Validate weather/env-effects (rain, clouds, haze, etc.) #312

kb173 opened this issue Mar 15, 2023 · 1 comment
Assignees
@kb173 @MathiasBaumgartinger
Labels
enhancement New feature or request

Comments

@kb173
Copy link
Member

kb173 commented Mar 15, 2023 •
edited
Loading

Four factors need to be taken into account in a more unified model:

  1. Cloud coverage
  2. Cloud density (+ lightning strikes?)
  3. Haze
  4. Lighting (directional vs ambient)
  5. Rain (amount & size)
@kb173 kb173 added the enhancement New feature or request label Mar 15, 2023
@kb173
Copy link
Member Author

kb173 commented May 3, 2023

We should test our implementation against reference images, e.g. a webcam like this: https://www.bergfex.at/sommer/wienerwald/webcams/c20882/

@kb173 kb173 self-assigned this May 3, 2023
MathiasBaumgartinger pushed a commit that referenced this issue Aug 2, 2023
feat: delete old rain-system and add newly implemented rain-system
134eccb 
The old rain system showed unflexibilities and had room for visual improvements, hence it was replaced

The new rain system is a fixed node that has rather clear parameters that dynamically change the rains behaviour

Refs: #312
@MathiasBaumgartinger MathiasBaumgartinger changed the title Implement rain and cloud stuff in a more "correct" way Implement weather/env-effects (rain, clouds, haze, etc.) in a more "correct" way Aug 4, 2023
MathiasBaumgartinger pushed a commit that referenced this issue Aug 4, 2023
feat/wip: add lightning to world scene and add ui controls
fa859d9 
WIP: lighting is part of World scene; lightning is randomly created somewhere around center node

WIP: adjust code such that it can be enabled from code (still buggy as of now)

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 7, 2023
feat: finishes lightning scene, adds more exposed options
ecd188c 
Lightning effects are visually polished and many options are exposed as export variables (color and albedo gradient, distance, spawn-interval).

Lightnings are now more "grouped" and arent just randomly spawned around the player; can be adjusted via rotation degrees

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 7, 2023
feat: expose rotation option of lightning scene to UI
92dcbb6 
Refs: #312 ; ecd188c
MathiasBaumgartinger pushed a commit that referenced this issue Aug 7, 2023
feat: add preconfigured weather categories
1fe6524 
Clear sky, few clouds, overcast, drizzle rain, gusts, thunderstorm, foggy can now be applied via dropdown

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 7, 2023
fix: volumetric fog is only applied upon reaching a certain threshold…
0ac3cd7 
…; disable rain and lightning by default

Before, volumetric fog was permanently applied which led to too dark sceneries when the sky is clear/no rain

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 7, 2023
feat: add new weather category "Heavy Rain"
4b7d888 
Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 7, 2023
feat: apply cloud-texture for lightning; change lightning behaviour f…
298aae3 
…or "weather lights"

Adds a texture that makes the clouds appear lit once a lightning strikes

Instead of always having a thunder, only by a certain change a true strike will be emitted otherwise "weather lights"

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 8, 2023
feat: implement environment effects in a more correct way
e9067d5 
SSAO and skylight are affected by cloud-coverage.

Clouds are not as strongly affected by a bright skylight (change in shader), therefore lights are stronger in general (bluer sky).

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 8, 2023
feat: expose cloud density parameter
187d26e 
Exposed in UI and in weathermanager, preconfigurations adjusted accordingly

Refs: #312
MathiasBaumgartinger pushed a commit that referenced this issue Aug 8, 2023
feat: apply wind settings to clouds
ce2f372 
Changes in the cloud shader were necessary; texture reads are multiplied with a wind-direction

Refs: #312
@MathiasBaumgartinger MathiasBaumgartinger mentioned this issue Aug 8, 2023
Merged
@kb173 kb173 changed the title Implement weather/env-effects (rain, clouds, haze, etc.) in a more "correct" way Validate weather/env-effects (rain, clouds, haze, etc.) Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kb173 kb173

@MathiasBaumgartinger MathiasBaumgartinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kb173 @MathiasBaumgartinger