Improve PHP 8 compatibility and testing #421
Conversation
|
@bobthecow Would appreciate eyes on this |
|
Some overlap with #404 |
| "phpunit/phpunit": "~3.7|~4.0|~5.0", | ||
| "friendsofphp/php-cs-fixer": "~1.11" | ||
| "friendsofphp/php-cs-fixer": "~2.19.3", | ||
| "yoast/phpunit-polyfills": "^2.0" |
There was a problem hiding this comment.
My biggest question here is whether we need to keep such old PHP version support, a such, such old PHPUnit version support... and therefore whether we actually need the polyfills at all
There was a problem hiding this comment.
For consuming projects like WP-CLI, PHP 5.6 is still required this year. After that, 7.0 or 7.2.
But even then, there is no single PHPUnit version that covers all PHP versions and is fully supported, see https://phpunit.de/supported-versions.html.
Plus, the polyfills provide forward compatibility, so that you can always use the latest PHPUnit features, even if you still need to use PHPUnit 8 for older PHP versions. Thus, this package is still very useful even if the project requires more modern PHP versions.
Bumps PHP requirement to 5.6+, runs tests against all PHP versions from 5.6 - 8.4
Fixes #374