Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: refactor docker release workflow and image metadata #59

Merged
merged 6 commits into from
Oct 10, 2023

Conversation

owen-reorg
Copy link
Collaborator

@owen-reorg owen-reorg commented Sep 27, 2023

Description

Refactor Docker release workflow and image metadata.

Rationale

Previously, the Docker release workflow built and published the Docker image only when a v* tag was pushed. However, we now have additional scenarios where we need the Docker image, such as deploying and testing a specific feature before its release. Therefore, we have added more conditions that will trigger the building of Docker images.

Example

Events and the associated docker tags

Event Ref Docker Tags
push refs/heads/main main
push refs/heads/develop develop
push tag refs/tags/v1.2.3 v1.2.3, 1.2.3
push tag refs/tags/v2.0.8-beta.67 v2.0.8-beta.67, 2.0.8-beta.67
workflow_dispatch refs/heads/main main

A tag associated with the given git commit hash like sha-ad132f5 will also be added.

Changes

Notable changes:

  • Modified the trigger conditions.
  • Included additional tags and metadata.
  • Eliminated the cache configuration as it provides minimal assistance for multi-stage Docker builds.

@owen-reorg owen-reorg force-pushed the ci-docker-image branch 2 times, most recently from 788ce0d to 00c0522 Compare September 27, 2023 09:55
Copy link
Contributor

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg changed the title ci: Refactor Docker release workflow and image metadata ci: refactor docker release workflow and image metadata Oct 10, 2023
Copy link
Contributor

@bendanzhentan bendanzhentan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-reorg owen-reorg merged commit 59bac7c into bnb-chain:develop Oct 10, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants