fix(op-node): l1 client use eth_getFinalizedBlock to get finalized block #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
Although the changes in this pull request (PR) will not result in a hard fork, they will modify the behavior related to returning the "finalize" block height. It is advisable to put this on hold for now and release it as part of a hard fork plan. |
|
ghcr.io/bnoieh/op-node:pr.36.96553e3 |
owen-reorg
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changed rpc method of get finalized L1 block
Rationale
There are two methods to get finalized block on BSC:
first one only return the fastFinalizedHeader, which is not exactly finalizedHeader when fast finality action failed.
second one is a bsc specific rpc method to always return right finalizedHeader.
currently we used first one, and we should use second one instead
Example
N/A
Changes
This PR changes l1Client to use second method instead of first one