fix: dont solely depend on the information from the L1 client to predict whether the transaction is committed #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ict whether the transaction is committed
bendanzhentan
force-pushed
the
fix-dont-rely-on-rpc-eth-gettransactionscount
branch
from
b4474ad
to
6bc5309
Compare
bendanzhentan
deleted the
fix-dont-rely-on-rpc-eth-gettransactionscount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the observation of testnet, MegaNode may have such a problem:
eth_getTransactionsCount's base on block height ofXeth_estimateGas's base block height isX-1As a result of the inconsistent performance of different interfaces, we are not able to simply determine whether a withdrawal has been processed by using a nonce check.
The PR adds a local timestamp check for fault tolerance.