Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[audit.l03] Index The L2Token in the WithdrawTo event #21

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

bendanzhentan
Copy link
Contributor

@bendanzhentan bendanzhentan commented Dec 6, 2023

For improved search-ability, in the WithdrawTo event, the l2Token parameter should be indexed. When parameters are indexed, they create a search-able index of the data. This feature helps users or external entities to find specific events that happened on the blockchain more efficiently, using the indexed parameter as a filter.

Copy link

@welkin22 welkin22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bendanzhentan bendanzhentan changed the base branch from main to develop December 8, 2023 03:30
@bendanzhentan bendanzhentan merged commit 0655faa into develop Dec 8, 2023
2 checks passed
@bendanzhentan bendanzhentan deleted the audit.l03 branch December 8, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants