feat: add listing table to fix monitor interval mismatch between bsc and gnfd #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monitor/gnfd_block_processor.go
Outdated
| @@ -230,6 +232,14 @@ func (p *GnfdBlockProcessor) handleEventCreateGroup(blockHeight uint64, event ab | |||
| return rawSql, err | |||
| } | |||
|
|
|||
| listing, err := p.listingDao.GetByGroupId(context.Background(), int64(createGroup.GroupId.Uint64())) | |||
| if err == nil { | |||
There was a problem hiding this comment.
check whether listing is nil or not?
| @@ -230,6 +232,14 @@ func (p *GnfdBlockProcessor) handleEventCreateGroup(blockHeight uint64, event ab | |||
| return rawSql, err | |||
| } | |||
|
|
|||
| listing, err := p.listingDao.GetByGroupId(context.Background(), int64(createGroup.GroupId.Uint64())) | |||
| if err == nil { | |||
| return fmt.Sprintf("insert into items (category_id, group_id, group_name, name, owner_address, status, description, url, listed_at, created_gnfd_height, price)"+ | |||
There was a problem hiding this comment.
set price as well here
| @@ -51,7 +51,7 @@ func configureAPI(api *operations.MindMarketplaceAPI) http.Handler { | |||
|
|
|||
| go func() { | |||
| http.Handle("/metrics", promhttp.Handler()) | |||
| util.Logger.Fatal(http.ListenAndServe(":9292", nil)) | |||
| util.Logger.Fatal(http.ListenAndServe(":9293", nil)) | |||
There was a problem hiding this comment.
do not commit this change, it will affect the metrics in testnet/mainnet
dao/listing.go
Outdated
|
|
||
| func (dao *DbListingDao) GetByGroupId(context context.Context, groupId int64) (database.Listing, error) { | ||
| var item = database.Listing{} | ||
| if err := dao.db.Preload("Stats").Where("group_id = ?", groupId).Take(&item).Error; err != nil { |
There was a problem hiding this comment.
Listing has no Stats field. No preload is needed.
database/listing.go
Outdated
| type Listing struct { | ||
| Id int64 `json:"id" gorm:"primaryKey"` | ||
| Price decimal.Decimal `json:"price" gorm:"type:decimal(65,0);"` | ||
| ListBscHeight uint64 `gorm:"NOT NULL;index:idx_list_bsc_height"` |
There was a problem hiding this comment.
remove index:idx_list_bsc_height this
dao/listing.go
Outdated
| } | ||
|
|
||
| func (dao *DbListingDao) GetByGroupId(context context.Context, groupId int64) (database.Listing, error) { | ||
| var item = database.Listing{} |
There was a problem hiding this comment.
rename item to listing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add listing table to fix monitor interval mismatch between bsc and gnfd