fix: unlock shadow-object balance when a bucket is force deleted #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
approved these changes
Mar 8, 2024
keefel
reviewed
Mar 8, 2024
| @@ -341,6 +341,15 @@ func (k Keeper) ForceDeleteBucket(ctx sdk.Context, bucketId sdkmath.Uint, cap ui | |||
| return false, deleted, err | |||
| } | |||
| k.SetInternalBucketInfo(ctx, bucketInfo.Id, internalBucketInfo) | |||
|
|
|||
| // if an object is updating, also need to unlock the shadowObject fee | |||
| if objectInfo.IsUpdating { | |||
There was a problem hiding this comment.
Because this feature not eanbled on testnet I think, so it is not hardfork?
unclezoro
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the force delete bucket scenario, there might be objects being updated, should unlock the shadow object balance.
Rationale
tell us why we need these changes...
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts