fix: disallow update payment address when there are created/updating objects #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
forcodedancing
force-pushed
the
disallow_change_payment
branch
4 times, most recently
from
d8bd1c9 to
fcf7a66
Compare
|
Please submit to master branch |
j75689
reviewed
Mar 7, 2024
keefel
reviewed
Mar 7, 2024
x/storage/keeper/abci.go
Outdated
| ctx.Logger().Error("should not happen, fail to delete buckets, err " + err.Error()) | ||
| panic("should not happen") | ||
| doDeleteBucket := true | ||
| if ctx.BlockHeight() > 5946511 && ctx.ChainID() == "greenfield_5600-1" { |
There was a problem hiding this comment.
Shall we add some comments here on why we need this?
keefel
previously approved these changes
Mar 7, 2024
unclezoro
reviewed
Mar 8, 2024
| @@ -123,7 +124,12 @@ func (k Keeper) UpdateFrozenStreamRecord(ctx sdk.Context, streamRecord *types.St | |||
| streamRecord.LockBalance = streamRecord.LockBalance.Add(change.LockBalanceChange) | |||
| streamRecord.StaticBalance = streamRecord.StaticBalance.Sub(change.LockBalanceChange) | |||
| if streamRecord.LockBalance.IsNegative() { | |||
| return fmt.Errorf("lock balance can not become negative, current: %s", streamRecord.LockBalance) | |||
| if ctx.IsUpgraded(upgradetypes.Pawnee) { | |||
| streamRecord.StaticBalance = streamRecord.StaticBalance.Add(streamRecord.LockBalance) | |||
There was a problem hiding this comment.
what if staticbalance become negative? is it possible?
There was a problem hiding this comment.
For the stream record is frozen, it will be negative.
When deposit, the user need to cover the fund.
unclezoro
reviewed
Mar 8, 2024
| @@ -158,7 +164,12 @@ func (k Keeper) UpdateStreamRecord(ctx sdk.Context, streamRecord *types.StreamRe | |||
| streamRecord.LockBalance = streamRecord.LockBalance.Add(change.LockBalanceChange) | |||
| streamRecord.StaticBalance = streamRecord.StaticBalance.Sub(change.LockBalanceChange) | |||
| if streamRecord.LockBalance.IsNegative() { | |||
| return fmt.Errorf("lock balance can not become negative, current: %s", streamRecord.LockBalance) | |||
| if ctx.IsUpgraded(upgradetypes.Pawnee) { | |||
There was a problem hiding this comment.
Yes. It could be negative. As when we locking more fund into buffer balance, if the static balance is negative. The new needs to pay for it.
unclezoro
reviewed
Mar 8, 2024
| @@ -334,6 +335,9 @@ func (k Keeper) ForceDeleteBucket(ctx sdk.Context, bucketId sdkmath.Uint, cap ui | |||
| ctx.Logger().Error("unlock store fee error", "err", err) | |||
| return false, deleted, err | |||
| } | |||
| if ctx.IsUpgraded(upgradetypes.Pawnee) { | |||
There was a problem hiding this comment.
For this, I think the SP need run a job: scan all the stale created object and reject seal them.
There was a problem hiding this comment.
If we can reject seal the stale created object, it will be better. I checked greenfieldscan, cannot find the stale created objects easily.
alexgao001
reviewed
Mar 8, 2024
alexgao001
reviewed
Mar 8, 2024
| @@ -1039,6 +1062,9 @@ func (k Keeper) ForceDeleteObject(ctx sdk.Context, objectId sdkmath.Uint) error | |||
| ctx.Logger().Error("unlock store fee error", "err", err) | |||
| return err | |||
| } | |||
| if ctx.IsUpgraded(upgradetypes.Pawnee) { | |||
| k.DecreaseCreatedObjectCount(ctx, bucketInfo.Id) | |||
| } | |||
| } else if objectStatus == types.OBJECT_STATUS_SEALED { | |||
| internalBucketInfo := k.MustGetInternalBucketInfo(ctx, bucketInfo.Id) | |||
| err := k.UnChargeObjectStoreFee(ctx, bucketInfo, internalBucketInfo, objectInfo) | |||
There was a problem hiding this comment.
if there is object being updated, update the payment addr is not allowed?
There was a problem hiding this comment.
added related codes, please check.
forcodedancing
force-pushed
the
disallow_change_payment
branch
from
6dfee73 to
b12488c
Compare
forcodedancing
force-pushed
the
disallow_change_payment
branch
from
dd74b40 to
6af6cd2
Compare
forcodedancing
force-pushed
the
disallow_change_payment
branch
from
d7881ce to
8d672ac
Compare
forcodedancing
changed the title
alexgao001
approved these changes
Mar 8, 2024
unclezoro
approved these changes
Mar 11, 2024
keefel
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
Bug fix
Example
NA
Changes
Notable changes:
Potential Impacts