-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow SP to create/update object for delegator #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexgao001
force-pushed
the
delegated_agent_create_object
branch
from
February 29, 2024 10:14
bd63877
to
d753e9e
Compare
alexgao001
changed the title
feat: delegated agent can create and update object
feat: SP create object for delegator
Mar 4, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
reviewed
Mar 5, 2024
unclezoro
previously approved these changes
Mar 8, 2024
alexgao001
changed the title
feat: SP create object for delegator
feat: allow SP to create/update object for delegator
Mar 11, 2024
yutianwu
reviewed
Mar 12, 2024
yutianwu
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a bucket is created, the primary SP is default be able to create objects for delegator(owner, or any entitled users), so that users can upload to SP directly without first creating the object meta on-chain. Bucket owner has option to disable such feature.
Rationale
accelerate the object creation process.
Example
add an example CLI or API response...
Changes
Notable changes:
Potential Impacts