Fix docs to say that the Dockerfile is created, not the image
#1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmuschko
requested changes
Dec 21, 2023
| @@ -6,7 +6,7 @@ The plugin provides a set of tasks for your project and preconfigures them with | |||
| |======= | |||
| |Task name |Depends On |Type |Description | |||
| |`dockerSyncBuildContext` |`classes` |TaskProvider<{uri-gradle-docs}/javadoc/org/gradle/api/tasks/Sync.html[Sync]> |Copies the application files to a temporary directory for image creation. | |||
| |`dockerCreateDockerfile` |`dockerSyncBuildContext` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/Dockerfile.html[Dockerfile]> |Creates the Docker image for the Java application. | |||
| |`dockerCreateDockerfile` |`dockerSyncBuildContext` |TaskProvider<{uri-ghpages}/api/com/bmuschko/gradle/docker/tasks/image/Dockerfile.html[Dockerfile]> |Creates the `Dockerfile` for the Java application. | |||
There was a problem hiding this comment.
Can you make the same change in 33-tasks.adoc?
There was a problem hiding this comment.
Sure, commit amended and force-pushed.
sschuberth
force-pushed
the
dockerfile-doc-fix
branch
from
c1b4e5a to
24d2f4a
Compare
|
Thanks for the pull request. It has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a trivial docs fix without an associated issue.