Skip to content

Commit

Permalink
fix: issue #217 when using a number as the target it is converted to …
Browse files Browse the repository at this point in the history
…a number in the yaml spec. Now convert it to a string to prevent this.
  • Loading branch information
jortbmd committed Dec 23, 2024
1 parent b96d745 commit a30a1af
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 3 deletions.
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,10 @@
- Issue #206: Did not build anything else than elf files due to the all recipe not being correct.
- Issue #212: On Windows threw an error because the build folder was already there. Now checks before using the md command. Thanks to: qwertym88

### Fix
### Fixed
- Reverted to single name build instead of a file tree based build output.
- Linkerscript now uses a file for the objects it needs to link to prevent Windows based command line length issues.
- Issue #217 when using a number as the target it is converted to a number in the yaml spec. Now convert it to a string to prevent this.

## [3.2.8] - 2024-09-05
### Added
Expand Down
2 changes: 1 addition & 1 deletion src/getInfo/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ export async function getInfo(location: string): Promise<MakeInfo> {
}

// replace spaces with underscores, to prevent spaces in path issues.
STM32MakeInfo.target = projectConfiguration.target.split(' ').join('_');
STM32MakeInfo.target = `${projectConfiguration.target}`.split(' ').join('_');
STM32MakeInfo.cIncludes = uniq([...includeDirectories, ...filteredIncludeDirectories]);
STM32MakeInfo.cxxSources = sortedSourceFiles.cxxSources;
STM32MakeInfo.cSources = sortedSourceFiles.cSources;
Expand Down
2 changes: 1 addition & 1 deletion src/types/MakeInfo.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ export class ExtensionConfiguration implements ExtensionConfigurationInterface {
this.optimization = makeInfo.optimization;
this.ldscript = makeInfo.ldscript;
this.targetMCU = makeInfo.targetMCU;
this.target = makeInfo.target;
this.target = `${makeInfo.target}`;
}
}

Expand Down

0 comments on commit a30a1af

Please sign in to comment.