Allow specifying the Redfish system name: #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Redfish implementations that manage multiple systems bening able to specify the system name is required. This is the case with sushy-tools, which is a redfish emulator for libvirt and others. Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
update-virtualmedia
branch
from
10873c2 to
2e4cfbb
Compare
joelrebel
reviewed
Oct 22, 2024
| return nil, err | ||
| } | ||
|
|
||
| return c.matchingSystem(s), nil |
There was a problem hiding this comment.
edit: ignore this comment - I now see the method defaults to returning all Systems.
We'd want to keep the default behavior here - to return all Systems - when c.systemName was not specified
Suggested change
| return c.matchingSystem(s), nil | |
| if c.systemName != "" { | |
| return c.matchingSystem(s), nil | |
| } | |
| return s, nil |
| @@ -120,6 +127,8 @@ func New(host, user, pass string, log logr.Logger, opts ...Option) *Conn { | |||
| redfishwrapper.WithHTTPClient(defaultConfig.HttpClient), | |||
| redfishwrapper.WithVersionsNotCompatible(defaultConfig.VersionsNotCompatible), | |||
| redfishwrapper.WithEtagMatchDisabled(defaultConfig.DisableEtagMatch), | |||
| redfishwrapper.WithBasicAuthEnabled(defaultConfig.UseBasicAuth), | |||
joelrebel
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
For Redfish implementations that manage multiple systems being able to specify the system name is required to be able to interact with the desired machine. This is the case with sushy-tools, which is a redfish emulator for libvirt and others. Also, enabling redfish basic auth was not plumbed through and is now.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes