Update virtual media mounting: #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least one BMC, Supermicro SYS-E300-D9, did not support setting inserted and/or writeProtected properties in redfish calls to do a virtual media mount. This falls back to not using them if the initial call with them in the properties fails. This was test and worked successfully on a Supermicro (SYS-E300-D9), HP ILO5, and Dell iDRAC9. Signed-off-by: Jacob Weinstock <[email protected]>
joelrebel
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Thanks for adding SMC support and testing this out, would you mind adding in an example snippet for reference into https://github.com/bmc-toolbox/bmclib/tree/main/examples
This helps understand and maintain-ability. Decreases the complexity of the function too. Signed-off-by: Jacob Weinstock <[email protected]>
Thanks for the review. Will add an example. |
This helps users see how to use the virtual media mounting capabilities. Signed-off-by: Jacob Weinstock <[email protected]>
|
@joelrebel , ready for another review. please and thank you! |
joelrebel
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
At least one BMC, Supermicro X11SDV-4C-TLN2F, did not support setting
insertedand/orwriteProtectedin the payload properties in redfish calls to do a virtual media mount. This falls back to not using them if the initial call with them in the properties fails.This was test and worked successfully on a Supermicro (X11SDV-4C-TLN2F), HP ILO5, and Dell iDRAC9.
Checklist
The HW vendor this change applies to (if applicable)
The HW model number, product name this change applies to (if applicable)
The BMC firmware and/or BIOS versions that this change applies to (if applicable)
What version of tooling - vendor specific or opensource does this change depend on (if applicable)
Description for changelog/release notes